16 messages
Pull Request Reviews for Cloud Posse Projects
Arnoldas Brazys6 months ago
Hi guys, pushed my first pull request https://github.com/cloudposse/terraform-aws-lambda-function/pull/90 for aws provider v6
.region instead of .nameJames Stocker6 months ago
Hi, I raised this PR a few weeks ago to fix an issue with the module (as a new version of the helm provider has broken this module)
Is there anything I need to do to get it reviewed? Or should I just fork and start using a personal reslease?
https://github.com/cloudposse/terraform-aws-helm-release/pull/78
Is there anything I need to do to get it reviewed? Or should I just fork and start using a personal reslease?
https://github.com/cloudposse/terraform-aws-helm-release/pull/78
Jakub Wądołowski6 months ago
a regression fix for the recently released v1 of
cloudposse/cloudfront-s3-cdn/aws: https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/358Michael6 months ago
Here's a PR for the utils provider that looks to address a
panic: assignment to entry in nil map in the utils_component_config data source while also bumping the Atmos version to v1.189.0. I didn't add any examples/test/packer files, but I will gladly add them if we have a good representative test for it (https://github.com/cloudposse/terraform-provider-utils/pull/498)Meg Ashby6 months ago
Hiya, I have a PR open here: https://github.com/cloudposse/terraform-aws-waf/pull/118 for adding anti-DDS’s functionality, but I had a question about testing on the PR. (Also willing to wait for office hours if need be)
R
Robert6 months ago(edited)
Hello CloudPosse Team,
I noticed there is an issue and two PRs for MSK Multi-VPC Connectivity
• https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/pull/129
• https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/pull/136
• https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/issues/118
The number of changes is very small, but it would be a very helpful addition 🙏
I noticed there is an issue and two PRs for MSK Multi-VPC Connectivity
• https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/pull/129
• https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/pull/136
• https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/issues/118
The number of changes is very small, but it would be a very helpful addition 🙏
Meg Ashby5 months ago
may I please get the tests triggered on this PR: https://github.com/cloudposse/terraform-aws-waf/pull/119
Michael5 months ago
Would I be able to get a review on this PR? It introduces support for new AWS managed rule group configuration options and updates the AWS provider version constraint so that the component no longer fails with the module bump:
https://github.com/cloudposse-terraform-components/aws-waf/pull/50
https://github.com/cloudposse-terraform-components/aws-waf/pull/50
Yevdokiia Mazhak5 months ago
hey! is there any chance somebody could check on https://github.com/cloudposse/terraform-aws-vpc/pull/159?
Yangci Ou5 months ago(edited)
Two small documentation (no Terraform code updates) quick win PRs for the CloudFront related modules, specifying that when using CloudFront with WAFv2, use the ARN, whereas WAF Classic uses ID.
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/349
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/154
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/349
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/154
Jan Costandius5 months ago
Hello there - I have a PR that I would like to get reviewed. Please see: https://github.com/cloudposse/terraform-aws-vpc-peering/pull/72
Josh Simmonds5 months ago
👋 Hi friends. I have a PR I'd like to request review on. It's to add support into your cognito module for risk configurations: https://github.com/cloudposse-terraform-components/aws-cognito/pull/40 🫶
david5 months ago
would love a review please https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/56
Meg Ashby5 months ago
Following the module change to include acfp rules, adding it to the component here: https://github.com/cloudposse-terraform-components/aws-waf/pull/56
Michael5 months ago
Would I be able to get a quick review on this logic update that makes destroying Transit Gateway resources cleaner? We've been exercising tearing these resources down and identified some logic improvements:
https://github.com/cloudposse/terraform-aws-transit-gateway/pull/65
https://github.com/cloudposse/terraform-aws-transit-gateway/pull/65
Yangci Ou5 months ago
Quick & easy variable description PR (https://github.com/cloudposse/terraform-aws-efs/pull/158) in the EFS module to let consumers know that Elastic throughput is an option (which is also the AWS recommended option now). Closes https://github.com/cloudposse/terraform-aws-efs/issues/151