Please review expanding unit tests to atmos

https://github.com/cloudposse/atmos/pull/2173/changes

Question for you folks. Now that we can create components from upstream modules and even claude our own components, are ALL the cloudposse components still relevant and worth maintaining and creating new components? To push even further back, are there any modules that are so simple that aren't worth migrating to or using?

If any are flagged, will those repos be archived or will their readmes eventually be updated to use the newer/modern approach?

@Alexandre Feblot based on your findings, I pushed some updates to fix the provider aliases.
https://github.com/cloudposse/atmos/pull/2210

can you test with --use-version=2210

@Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/2330

https://github.com/cloudposse/atmos/pull/2129 @Andriy Knysh (Cloud Posse)

@Andriy Knysh (Cloud Posse) added missing redirects https://github.com/cloudposse/atmos/pull/2287

Any chance we could get another set of eyes on this bugfix https://github.com/cloudposse/atmos/pull/2184 🥺

@Andriy Knysh (Cloud Posse) minor one: https://github.com/cloudposse/atmos/pull/2323

@Andriy Knysh (Cloud Posse) this was verified by @Dan Hansen https://github.com/cloudposse/atmos/pull/2296

Moving this thread here:
https://github.com/cloudposse/atmos/pull/2309

@Andriy Knysh (Cloud Posse) improve error handling for atmos pro, to surface errors to users
https://github.com/cloudposse/atmos/pull/2316

@Andriy Knysh (Cloud Posse) this switches us from <http://autofix.ci|autofix.ci> to native support in atmos pro to commit files that will trigger workflow runs.
https://github.com/cloudposse/atmos/pull/2298

@Igor Rodionov https://github.com/cloudposse/atmos/pull/2300

@Igor Rodionov https://github.com/cloudposse/atmos/pull/2304

@Igor Rodionov https://github.com/cloudposse/atmos/pull/2306

@Andriy Knysh (Cloud Posse)
https://sweetops.slack.com/archives/CUJPCP1K6/p1775764244063079

cc @Jon Howard

@RB you're kicking butt

@Andriy Knysh (Cloud Posse) this is ready: https://github.com/cloudposse/atmos/pull/1984

@RB here's the mental hold up on merging this: https://github.com/cloudposse/atmos/pull/2123/changes#r3041795730

@RB let me know if you have any more PRs you want me to review. I know you have quite a few in flight.

@Andriy Knysh (Cloud Posse) this is a small one; suppress output from atmos describe affected by default when --upload is passed

https://github.com/cloudposse/atmos/pull/2284

@Andriy Knysh (Cloud Posse) this fixes color handling when using --provenance; manually verified it.

https://github.com/cloudposse/atmos/pull/2281

@Andriy Knysh (Cloud Posse) this PR from @Ben Smith (Benbentwo) LGTM
https://github.com/cloudposse/atmos/pull/2144

@Andriy Knysh (Cloud Posse) this PR from @Igor Rodionov LGTM
https://github.com/cloudposse/atmos/pull/2263

Dumb question. I was told to fork the project and make a PR. I did that with https://github.com/thejrose1984/atmos/pull/1 but I'm assuming that means nothing because it won't actually do anything to make a PR against the source

Could i get a review to close this small security finding from github codeql?

fix: clear-text logging of sensitive information (CodeQL #5157) #2163

@Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/2264 just improved the error messaging from Atmos uploads.

@Andriy Knysh (Cloud Posse): @Zack confirmed this fix is working: https://github.com/cloudposse/atmos/pull/2253

@Charles Smith I looked into what you reported on Office Hours.
https://github.com/cloudposse/atmos/pull/2254

@Andriy Knysh (Cloud Posse) this was validated by @Alexander Matveev
https://github.com/cloudposse/atmos/pull/2143

cc @Sean

do we have any tests that check for “speed” so an SLA/SLO can be created for various atmosy things?

Improve test coverage, please review

https://github.com/cloudposse/atmos/pull/2173/changes

@Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/2229
This fixes the problem where users try to log into the console with multiple identities and get an error from AWS.

prd to track and decrease cyclomatic complexity in order to improve test coverage and thus reduce future bugs

Related PRs

• https://github.com/cloudposse/atmos/pull/2226
• https://github.com/cloudposse/atmos/pull/2225
• https://github.com/cloudposse/atmos/pull/2204

Can we include the openssf scorecard in the atmos repo to improve security score ?

https://github.com/cloudposse/atmos/pull/2176/changes

reduce ExecuteDescribeStacks cyclomatic complexity 247→10 + near-100% unit test coverage

https://github.com/cloudposse/atmos/pull/2204/changes

@Andriy Knysh (Cloud Posse) I think this is ready
https://github.com/cloudposse/atmos/pull/2181

This PR fixes the last HIGH severity security issue in atmos

https://github.com/cloudposse/atmos/pull/2163/changes

@RB please start with PRDs for all the features. see docs/prds; without the PRD, cannot assess the scope easily and implementations tend to not follow conventions.

Last one, thoughts on adding a description key for humans and for ai context

https://github.com/cloudposse/atmos/pull/2200/changes

A possible way to improve the stack deep merge by 3.5 times

https://github.com/cloudposse/atmos/pull/2201/changes

Thoughts on linting stack yaml ?

https://github.com/cloudposse/atmos/pull/2203/changes

I recall we talked about a switch that would explain where every key came from post deep merge. This should give us that via --explain

https://github.com/cloudposse/atmos/pull/2199/changes

What do you guys think of having atmos plugins so each subcommand (validate/describe/terraform/helmfile) can be its own separate repo with its own versioned binary?

This way atmos can be a "shell" of a program and can be extendable e.g. you can do something like this

atmos plugin add validate@1.0.0
atmos plugin add terraform@1.2.3
atmos plugin add opentofu@2.0.0
etc

Thoughts on an import_if param ?

https://github.com/cloudposse/atmos/pull/2202/changes

@Andriy Knysh (Cloud Posse) I ran into this defining some custom commands. Manually verified this works for me.

https://github.com/cloudposse/atmos/pull/2191

@Andriy Knysh (Cloud Posse) this was hand validated by me (against examples/toolchain) and resolves a few of the recurring problems we've been having.
• Package dependency is not accessible after install.
• Uninstall command not removing package dependencies.
After this change, finally one-shotting, toolchain installation should be possible or working with atmos terraform commands.

https://github.com/cloudposse/atmos/pull/2172

@RB may need your help to finish this https://github.com/cloudposse/atmos/pull/2174#issuecomment-4052196897