pr-reviews
2993,392
Pull Request Reviews for Cloud Posse Projects
Ivan Pinatti10 days ago
This PR is from Renovate and is stuck, someone could review and unblock it please?
• github.com/cloudposse-terraform-components/aws-waf/pull/73
• github.com/cloudposse-terraform-components/aws-waf/pull/73
Michal Tomaszek10 days ago
Hey, follow-up of yesterday's PR:
github.com/cloudposse-terraform-components/aws-github-repository/pull/60
github.com/cloudposse-terraform-components/aws-github-repository/pull/60
MP11 days ago
Hello, could you review this PR ? github.com/cloudposse/atmos/pull/2914
Here is the issue as well => github.com/cloudposse/atmos/issues/2913
Here is the issue as well => github.com/cloudposse/atmos/issues/2913
Michal Tomaszek11 days ago
Hey, could you review this PR for
github.com/cloudposse/terraform-github-repository/pull/32
terraform-github-repository ?github.com/cloudposse/terraform-github-repository/pull/32
Jonathan14 days ago(edited)
Hello, the following PRs are ready for (re)review:
• github.com/cloudposse/atmos/pull/2820
• github.com/cloudposse/atmos/pull/2835
• github.com/cloudposse/atmos/pull/2833
• github.com/cloudposse/atmos/pull/2832
• github.com/cloudposse/atmos/pull/2820
• github.com/cloudposse/atmos/pull/2835
• github.com/cloudposse/atmos/pull/2833
• github.com/cloudposse/atmos/pull/2832
Sean16 days ago
Hello, github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/69 has been created to bring the defaults & functionality in line with the current cert-manager while providing the ability to retain older version behaviors if desired
Michael22 days ago
Would I be able to get one more PR review on this EKS feature?
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Jonathan22 days ago
Hi @Erik Osterman (Cloud Posse) let me know if you need anything else for https://github.com/cloudposse/atmos/pull/2820
david23 days ago
may I get a review please to allow for
not_resources in SCPs? github.com/cloudposse/terraform-aws-service-control-policies/pull/71Ivan Pinatti25 days ago
Two more PRs, this is to address a specific scenario using these component.
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
• github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
• github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Ivan Pinatti29 days ago
Hi everyone, could I get a review on this PR please? It is a bug fix.
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ben Smith (Benbentwo)30 days ago(edited)
affected by the
cloudposse/utils: no available releases match the given constraints
>= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0problem
Ben Smith (Benbentwo)about 1 month ago(edited)
S3 Bucket update to latest module + provider
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
Ben Smith (Benbentwo)about 1 month ago
Can i get a reveiw on github.com/cloudposse/terraform-aws-s3-bucket/pull/295
Marat Bakeevabout 1 month ago
Could anyone have a look at this PR for removing account-map dependency? github.com/cloudposse-terraform-components/aws-spa-s3-cloudfront/pull/68
Alex Renokiabout 1 month ago
Hi there, I eventually realized there is a lot on the plate for y’all and don’t see the GH notifications. 😅
Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the
Just so I know if I should close the PR and wait for the above PR to be finished.
Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the
atmos stack schema command (github.com/cloudposse/atmos/commit/0485a62a5c75…, github.com/cloudposse/atmos/pull/2761)Just so I know if I should close the PR and wait for the above PR to be finished.
Ivan Pinattiabout 1 month ago
Hey guys, I know you all have been busy. When you can, could someone please review these PRs? I shared them a while ago, but they have not been reviewed yet. They are mostly AWS Utils 2.x bumps and a few minor bug fixes.
• github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
• github.com/cloudposse-terraform-components/aws-teams/pull/65
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
• github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for
• github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7…
• github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
• github.com/cloudposse-terraform-components/aws-teams/pull/65
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
• github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for
aws-aurora-mysql was merged into main, but no release has been cut since then, could someone please cut a version so we can vendor it?• github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7…
PePe Amengualabout 1 month ago
https://github.com/cloudposse-terraform-components/aws-managed-grafana-workspace/pull/56 @Andriy Knysh (Cloud Posse)
PePe Amengualabout 1 month ago
what is the latest to the Utils module problem? https://github.com/cloudposse-terraform-components/aws-managed-grafana-workspace/actions/runs/25477300111/job/74753457841?pr=53 what can I do to fix that?
PePe Amengualabout 1 month ago
PR to add severity filters to https://github.com/cloudposse/terraform-aws-security-hub/pull/79
Michaelabout 1 month ago
Small PR for adding
iam_role_arn to the CloudFormation stack module: github.com/cloudposse/terraform-aws-cloudformation-stack/pull/39Chris Hardenabout 1 month ago
The acceptance test for windows timed out. Will you please fire it off again?
Ivan Pinattiabout 1 month ago
PR fixing a bug, when possible, could I get a review/approval?
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Chris Hardenabout 1 month ago
Ivan Pinattiabout 2 months ago
Could I please get a review on this PR? github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
Chris Hardenabout 2 months ago
Can I get a "Approve and run workflows" on github.com/cloudposse/atmos/pull/2674
Thanks!!
Thanks!!
Ivan Pinattiabout 2 months ago
---
Another PR for review please;
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
Another PR for review please;
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
Michaelabout 2 months ago
Would I be able to get a review on this PR that fixes the failing tests for the Redshift module? Had to update some of the outdated test values and migrate the
github.com/cloudposse/terraform-aws-redshift-cluster/pull/49
logging configuration to the new resource, but everything should be backwards compatible and included in the tests:github.com/cloudposse/terraform-aws-redshift-cluster/pull/49
davidabout 2 months ago
may I get a review please github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ivan Pinattiabout 2 months ago
Could I get a pair of eyes on this PR please?
• github.com/cloudposse-terraform-components/aws-teams/pull/65
remote-state 1.8.0 → 2.0.0 for utils 2.x compatibility• github.com/cloudposse-terraform-components/aws-teams/pull/65
Marat Bakeevabout 2 months ago(edited)
Can this PR get reviewed? github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
Allows to hide ArgoCD on internal alb and only expose webhooks
Allows to hide ArgoCD on internal alb and only expose webhooks
davidabout 2 months ago
may we get this old PR reviewed please, github.com/cloudposse/terraform-aws-waf/pull/130? It adds some functionality we are looking for. I can followup with a PR on the component as well
Michaelabout 2 months ago
Would I be able to get a small PR review to add the
hosted_zone_id output to the bucket module? github.com/cloudposse/terraform-aws-s3-bucket/pull/293Brian2 months ago
https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this
atmos secret list -s <stack> against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.Marat Bakeev2 months ago
Hi guys, somewhat large bump to cognito component - https://github.com/cloudposse-terraform-components/aws-cognito/pull/63
Let me know if this is not acceptable.
Let me know if this is not acceptable.
Marat Bakeev2 months ago
A small PR to add support for using local instance store disks in karpenter node pools - https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/73
Michael2 months ago
Not sure if the team would have any interest in this but it adds support for govcloud AWS accounts: https://github.com/cloudposse-terraform-components/aws-account/pull/56
Marat Bakeev2 months ago
Hey 👋 Opened a small bug-fix PR for the atmos ansible playbook command: https://github.com/cloudposse/atmos/pull/2594
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
ansible-playbook flags through.Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Michael2 months ago
Could I get a review of this change that fixes some tflint findings, typos, and adds support for
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
force_update_version and control_plane_scaling_config for the EKS module?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Quentin BERTRAND3 months ago
Hi Clouders!
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
Miguel Zablah3 months ago
PR to update module to AWS v6 and also update some modules:
https://github.com/cloudposse/terraform-aws-config/pull/141
https://github.com/cloudposse/terraform-aws-config/pull/141