pr-reviews
2993,002
Pull Request Reviews for Cloud Posse Projects
J
J
M
Michael5 days ago
Would I also be able to get a review on adding the
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/92
cloudwatch_metric_alarms_enabled configuration to the Elasticache Redis component?https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/92
D
david7 days ago
may I get a review please https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/85
J
Jonathan Rose8 days ago
Hello! May I get an update on chore(deps): update terraform cloudposse/repository/github to v1.1.0 by renovate[bot] · Pull Request #29 · cloudposse-terraform-components/aws-github-repository?
M
Michael9 days ago
Would I be able to get a Geodesic syntax and parsing error fix review?
https://github.com/cloudposse/geodesic/pull/982
https://github.com/cloudposse/geodesic/pull/982
M
Michael15 days ago
Would I be able to get a review on this PR that adds the ability to
https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/145
copy_tags_to_snapshots for DocumentDB?https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/145
M
Michael16 days ago
Would I be able to get a review on configuration support for the desync mitigation mode on the ALBs?
https://github.com/cloudposse/terraform-aws-alb/pull/206
https://github.com/cloudposse/terraform-aws-alb/pull/206
J
Jonathan Rose16 days ago
@Erik Osterman (Cloud Posse) lmk when I can test Fix: INLINECODE_0 fails with "failed to find import" when base ref has no stack files by Copilot · Pull Request #2185 · cloudposse/atmos 🙂
I
Ivan Pinatti16 days ago
Hello, could please someone reopen and approve this PR please? It was waiting approval and was automatically closed.
• https://github.com/cloudposse-terraform-components/aws-aurora-mysql/pull/59
• https://github.com/cloudposse-terraform-components/aws-aurora-mysql/pull/59
R
R
RB22 days ago
Please also review upgrading node runtime to node24 in github-action-pre-commit repo
https://github.com/cloudposse/github-action-pre-commit/pull/32/changes
https://github.com/cloudposse/github-action-pre-commit/pull/32/changes
R
RB22 days ago(edited)
Please review updating gha atmos affected stacks
• ✅️Fix test and dep upgrade https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/82/changes
• ✅️fix injection points https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/85/changes
• dep upgrades
◦ ⏳️aws-actions/configure v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/81/changes
◦ ✅️setup-node v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/76/changes
• ✅️renovate best practices https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/67/changes
• ✅️Fix test and dep upgrade https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/82/changes
• ✅️fix injection points https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/85/changes
• dep upgrades
◦ ⏳️aws-actions/configure v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/81/changes
◦ ✅️setup-node v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/76/changes
• ✅️renovate best practices https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/67/changes
R
RB27 days ago
S
Sean Nguyen27 days ago(edited)
The datadog
@johncblandii
https://github.com/cloudposse/terraform-datadog-platform/pull/125
monitors submodule is not compatible with the latest release of the DataDog Terraform provider.@johncblandii
https://github.com/cloudposse/terraform-datadog-platform/pull/125
R
RBabout 1 month ago
Please review atmos security updates https://github.com/cloudposse/atmos/pull/2123
R
RBabout 1 month ago
Please review setting default instance type for all redis clusters
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/82
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/82
R
RBabout 1 month ago
Please also review bumping the minimum aws provider for the elasticache redis component https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/81
R
RBabout 1 month ago
Please review adding global engine_version default for all redis clusters https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/80
R
RBabout 1 month ago
Please review allowing dns_subdomain to be overridden per cluster in redis clusters https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/79
A
aaireyabout 1 month ago
Hi can anyone please review:
• https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/81
• https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/81
R
R
R
RBabout 1 month ago
Expose the rest of elasticache redis inputs
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/68
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/68
I
Ivan Pinattiabout 1 month ago
Another one, expose
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
num_shards and replicas_per_shard as component-level variables• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
I
Ivan Pinattiabout 1 month ago
One more PR, now to enable Slow and Engine logs options for Redis
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/
I
Ivan Pinattiabout 1 month ago
PR adding maintenance and snapshot window options for Elasticache Redis
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/64
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/64
I
Ivan Pinattiabout 1 month ago
R
RBabout 1 month ago
Another set of eyes here pleae https://github.com/cloudposse/terraform-aws-dynamodb/pull/141
J
Jakub Wądołowskiabout 2 months ago
I've just created two straightforward PRs that add
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
response_completion_timeout support to both CDN modules:• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
R
RBabout 2 months ago
Please review setting bucket key to true default https://github.com/cloudposse/terraform-aws-s3-bucket/pull/285
J
Jakub Wądołowskiabout 2 months ago
a small enhancement for the ECS web app module: https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/305. Would appreciate a review when you get a chance
D
davidabout 2 months ago
May I get a review please https://github.com/cloudposse-terraform-components/aws-api-gateway-rest-api/pull/46
M
Michaelabout 2 months ago
Sorry, quick patch fix for Datadog tags in the EKS agent: https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/75
M
MPabout 2 months ago
Hello 👋
Would I be able to get a review for this PR => https://github.com/cloudposse/atmos/pull/2058 ?
Reference: https://sweetops.slack.com/archives/C031919U8A0/p1770405166302539
Would I be able to get a review for this PR => https://github.com/cloudposse/atmos/pull/2058 ?
Reference: https://sweetops.slack.com/archives/C031919U8A0/p1770405166302539
M
Michaelabout 2 months ago
Small PR fix for Cognito component's failing validation: https://github.com/cloudposse-terraform-components/aws-cognito/pull/50
M
Michaelabout 2 months ago
Small PR for fixing a Datadog tag parsing misinterpretation: https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/74
R
RB2 months ago
Please review changes to https://github.com/cloudposse-terraform-components/aws-account-settings/pull/52/files
M
Michael2 months ago
Would I be able to get a review on this bug fix? The change ensures that the validation conditions correctly handle
https://github.com/cloudposse-terraform-components/aws-cloudtrail-bucket/pull/56
null values by using a ternary operator instead of relying on logical OR, which can help avoid issues with type coercion.https://github.com/cloudposse-terraform-components/aws-cloudtrail-bucket/pull/56
I
Ivan Pinatti2 months ago
Could I get one more review? ECS Component Naming fix
• https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/pull/79
• https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/pull/79
I
Ivan Pinatti2 months ago
Hello everyone, happy Friday!
Could I get an approval for this PR? Finer Controls for S3 Events Notifications;
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/76
Could I get an approval for this PR? Finer Controls for S3 Events Notifications;
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/76
B
Bruce2 months ago
bumping default python version on datadog-lambda-forwarder like the module:
https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/91
https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/91
C
Cilas Beltrame3 months ago
just re-pinging this again
N
Nitin3 months ago
Hello everyone, can you please review this PR
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
B
Bruce3 months ago
client vpn component broke after latest update:
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
M
Marat Bakeev4 months ago
Hi everyone, can you please review this PR - https://github.com/cloudposse-terraform-components/aws-eks-alb-controller-ingress-class/pull/50
M
Michael4 months ago
May I get a review on this Geodesic PR? https://github.com/cloudposse/geodesic/pull/980
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
array=($(command)) with the more robust mapfile -t array < <(command) syntax- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
T
Tyler Rankin4 months ago
Irregular contributor here 👋
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
/test that need to be made. Thanks!https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
D
david4 months ago
May I get a review on this SQS -> Lambda trigger please https://github.com/cloudposse-terraform-components/aws-lambda/pull/44
E