pr-reviews
2993,260
Pull Request Reviews for Cloud Posse Projects
Ivan Pinatti2 days ago
PR fixing a bug, when possible, could I get a review/approval?
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Chris Harden3 days ago
Ivan Pinatti9 days ago
Could I please get a review on this PR? github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
Chris Harden9 days ago
Can I get a "Approve and run workflows" on github.com/cloudposse/atmos/pull/2674
Thanks!!
Thanks!!
Ivan Pinatti10 days ago
---
Another PR for review please;
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
Another PR for review please;
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
Michael11 days ago
Would I be able to get a review on this PR that fixes the failing tests for the Redshift module? Had to update some of the outdated test values and migrate the
github.com/cloudposse/terraform-aws-redshift-cluster/pull/49
logging configuration to the new resource, but everything should be backwards compatible and included in the tests:github.com/cloudposse/terraform-aws-redshift-cluster/pull/49
david11 days ago
may I get a review please github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ivan Pinatti11 days ago
Could I get a pair of eyes on this PR please?
• github.com/cloudposse-terraform-components/aws-teams/pull/65
remote-state 1.8.0 → 2.0.0 for utils 2.x compatibility• github.com/cloudposse-terraform-components/aws-teams/pull/65
Marat Bakeev13 days ago(edited)
Can this PR get reviewed? github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
Allows to hide ArgoCD on internal alb and only expose webhooks
Allows to hide ArgoCD on internal alb and only expose webhooks
david15 days ago
may we get this old PR reviewed please, github.com/cloudposse/terraform-aws-waf/pull/130? It adds some functionality we are looking for. I can followup with a PR on the component as well
Michael15 days ago
Would I be able to get a small PR review to add the
hosted_zone_id output to the bucket module? github.com/cloudposse/terraform-aws-s3-bucket/pull/293Brian21 days ago
https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this
atmos secret list -s <stack> against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.Marat Bakeev23 days ago
Hi guys, somewhat large bump to cognito component - https://github.com/cloudposse-terraform-components/aws-cognito/pull/63
Let me know if this is not acceptable.
Let me know if this is not acceptable.
Marat Bakeev27 days ago
A small PR to add support for using local instance store disks in karpenter node pools - https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/73
Michaelabout 1 month ago
Not sure if the team would have any interest in this but it adds support for govcloud AWS accounts: https://github.com/cloudposse-terraform-components/aws-account/pull/56
Marat Bakeevabout 1 month ago
Hey 👋 Opened a small bug-fix PR for the atmos ansible playbook command: https://github.com/cloudposse/atmos/pull/2594
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
ansible-playbook flags through.Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Michaelabout 1 month ago
Could I get a review of this change that fixes some tflint findings, typos, and adds support for
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
force_update_version and control_plane_scaling_config for the EKS module?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Quentin BERTRANDabout 1 month ago
Hi Clouders!
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
Miguel Zablahabout 1 month ago
PR to update module to AWS v6 and also update some modules:
https://github.com/cloudposse/terraform-aws-config/pull/141
https://github.com/cloudposse/terraform-aws-config/pull/141
Michaelabout 1 month ago
Small PR after running tflint on the s3 bucket module: https://github.com/cloudposse-terraform-components/aws-s3-bucket/pull/82
Jonathanabout 1 month ago
May I get reviews please?
https://github.com/cloudposse/atmos/pull/2549
https://github.com/cloudposse/atmos/pull/2548
https://github.com/cloudposse/atmos/pull/2547
https://github.com/cloudposse/atmos/pull/2549
https://github.com/cloudposse/atmos/pull/2548
https://github.com/cloudposse/atmos/pull/2547
PePe Amengualabout 1 month ago
Jonathanabout 1 month ago
May I get reviews?
https://github.com/cloudposse/atmos/pull/2541
https://github.com/cloudposse/atmos/pull/2540
https://github.com/cloudposse/atmos/pull/2541
https://github.com/cloudposse/atmos/pull/2540
Jonathanabout 1 month ago
May I get a review of https://github.com/cloudposse/atmos/pull/2533 please?
Ben Smith (Benbentwo)about 1 month ago
I have a relatively simple PR https://github.com/cloudposse-terraform-components/aws-managed-grafana-dashboard/pull/47 (new var input directly into resource) it fails with the issue of
do you want a new PR to update to Remote-state 2.0.0? Same PR? seems like this is an issue across many components, perhaps the range
│ Could not retrieve the list of available versions for provider
│ cloudposse/utils: no available releases match the given constraints >=
│ 0.3.0, >= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0do you want a new PR to update to Remote-state 2.0.0? Same PR? seems like this is an issue across many components, perhaps the range
>= 1.7.1, < 3.0.0 would work (more forgiving for 2.X.Y releases that IIRC didn't have breaking changes)PePe Amengualabout 2 months ago
Hi CP I have a PR for review https://github.com/cloudposse/terraform-aws-transit-gateway/pull/67 to add
asn to the TGW componentArnoldas Brazysabout 2 months ago
Hi team,
datadog integration been dragging with deprecation warnings since v2, now v4 already available, who could look into it?
https://github.com/cloudposse/terraform-aws-datadog-integration/pull/73
datadog integration been dragging with deprecation warnings since v2, now v4 already available, who could look into it?
https://github.com/cloudposse/terraform-aws-datadog-integration/pull/73
erikabout 2 months ago
@Igor Rodionov
Marat Bakeevabout 2 months ago
N.B. - the pipeline seems unhappy
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider
│ cloudposse/utils: no available releases match the given constraints >=
│ 0.3.0, >= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0Marat Bakeevabout 2 months ago
And another request - support for making ArgoCD internal, while still exposing its webhook receiver publicly.
https://github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
https://github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
Marat Bakeevabout 2 months ago
Hi team, can someone have a look at this PR that adds support for custom MAIL FROM domain in the ses component?
https://github.com/cloudposse-terraform-components/aws-ses/pull/69
https://github.com/cloudposse-terraform-components/aws-ses/pull/69
Jonathanabout 2 months ago
May I get a review of https://github.com/cloudposse/atmos/pull/2486 please?
Jonathanabout 2 months ago
May I get a review of https://github.com/cloudposse/atmos/pull/2484 please?
Michaelabout 2 months ago
Would I be able to get a PR that adds
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/260
deletion_protection for EKS clusters?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/260
Jonathanabout 2 months ago(edited)
May I get reviews please?
• https://github.com/cloudposse/atmos/pull/2477
• https://github.com/cloudposse/atmos/pull/2478
• https://github.com/cloudposse/atmos/pull/2477
• https://github.com/cloudposse/atmos/pull/2478
Jonathanabout 2 months ago
May I get a review of https://github.com/cloudposse/atmos/pull/2430 please?
Tyrone Meijnabout 2 months ago
Hi 👋 I submitted a fix for the classic plan time for_each issue: https://github.com/cloudposse/terraform-aws-iam-role/pull/92
Jakub Wądołowskiabout 2 months ago
hey! I just submitted a minor monitoring improvement to both
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/162
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/372
cloudposse/cloudfront-cdn/aws and cloudposse/cloudfront-s3-cdn/aws modules:• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/162
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/372
Josh Simmondsabout 2 months ago
👋 Hi friends! PR here to bolster the native CI rewrite and fix issue 2367 (native CI not posting to PRs): https://github.com/cloudposse/atmos/pull/2405
Ben Smith (Benbentwo)2 months ago
Could i get a review on https://github.com/cloudposse-terraform-components/aws-iam-role/pull/64
Ivan Pinatti2 months ago
Could I please get an approval for this bugfix?
https://github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/51
https://github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/51
Michael2 months ago
If anyone has a chance, this adds some additional parameters to the VPC flow logs in the
vpc component: https://github.com/cloudposse-terraform-components/aws-vpc/pull/93PePe Amengual2 months ago
continuation of the fixes https://github.com/cloudposse/terraform-aws-sso/pull/77
PePe Amengual3 months ago
Please take a look https://github.com/cloudposse-terraform-components/aws-identity-center/pull/74 thanks
Quentin BERTRAND3 months ago
PR to add
feat: add bucket_namespace argument
bucket_namespace to allow regional namespace usage in terraform-aws-s3-bucket modulefeat: add bucket_namespace argument
Michal Tomaszek3 months ago
PR to improve importing of environments in repositories:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/50
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/50