pr-reviews
2993,089
Pull Request Reviews for Cloud Posse Projects
M
Michal Tomaszekabout 3 hours ago
PR to improve importing of environments in repositories:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/50
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/50
M
Michal Tomaszekabout 10 hours ago
PR for component to handle webhook secret as a sensitive data:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/49
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/49
M
Michal Tomaszekabout 11 hours ago
PR for handling webhook secret as a sensitive data:
https://github.com/cloudposse/terraform-github-repository/pull/28
https://github.com/cloudposse/terraform-github-repository/pull/28
M
Michal Tomaszekabout 12 hours ago
Hey, could you check this one?
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/48
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/48
I
Ivan Pinatti1 day ago
Hello, could I get a pair of eyes and approval on these two PRs please? One was already approved but failed the tests and now it is corrected.
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/92
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/92
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
S
Stanislava Racheva4 days ago(edited)
Hello everyone, would someone please review https://github.com/cloudposse/terraform-aws-rds-cluster/pull/282
Its about making the random pet name suffix optional which prevents rds instances re-creation.
@Igor Rodionov @Joe Niland would you please take a look when you have some time, very much appreciated!
Its about making the random pet name suffix optional which prevents rds instances re-creation.
@Igor Rodionov @Joe Niland would you please take a look when you have some time, very much appreciated!
J
Jonathan Rose6 days ago
M
Michael6 days ago
A follow up PR to add blue green updates to the RDS component as well: https://github.com/cloudposse-terraform-components/aws-rds/pull/65
M
Michael7 days ago
If anyone has a chance to review, this adds support for blue green updates to the RDS module:
https://github.com/cloudposse/terraform-aws-rds/pull/206
https://github.com/cloudposse/terraform-aws-rds/pull/206
M
M
Michal Tomaszek7 days ago
And one for
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/41
aws-github-repository root module - missing field:https://github.com/cloudposse-terraform-components/aws-github-repository/pull/41
M
Michal Tomaszek7 days ago
Hi, another PR for
https://github.com/cloudposse/terraform-github-repository/pull/23
terraform-github-repository module to make it more flexible;https://github.com/cloudposse/terraform-github-repository/pull/23
M
Michal Tomaszek8 days ago
Hey, could you review this one, too?:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/40
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/40
I
Ivan Pinatti8 days ago
Could I get some eyes and approval on this PR please?
https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
M
Michal Tomaszek8 days ago(edited)
Hi, could you review this PR? - a small fix:
https://github.com/cloudposse/terraform-github-repository/pull/22
https://github.com/cloudposse/terraform-github-repository/pull/22
J
Jonathan Rose11 days ago
Hello! May I get a review of https://github.com/cloudposse/terraform-github-repository/pull/21?
J
Jon Howard12 days ago
I've created a pull request to resolve Issue #2258 so that
https://github.com/cloudposse/atmos/pull/2305
atmos terraform plan-diff properly processes templates, functions, and respects the --skip-init flag.https://github.com/cloudposse/atmos/pull/2305
D
david17 days ago
Two related PRs for review please. This allows us to use more recent versions of the datadog lambda forwader:
• https://github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/69
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/103
• https://github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/69
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/103
M
Michael19 days ago
Would I be able to get a review on this PR that adds
https://github.com/cloudposse/terraform-aws-mwaa/pull/74
worker_replacement_strategy configurations while maintaining backwards compatibility for the MWAA module?https://github.com/cloudposse/terraform-aws-mwaa/pull/74
J
J
M
Michael25 days ago
Would I also be able to get a review on adding the
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/92
cloudwatch_metric_alarms_enabled configuration to the Elasticache Redis component?https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/92
D
david27 days ago
may I get a review please https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/85
J
Jonathan Rose28 days ago
Hello! May I get an update on chore(deps): update terraform cloudposse/repository/github to v1.1.0 by renovate[bot] · Pull Request #29 · cloudposse-terraform-components/aws-github-repository?
M
Michael29 days ago
Would I be able to get a Geodesic syntax and parsing error fix review?
https://github.com/cloudposse/geodesic/pull/982
https://github.com/cloudposse/geodesic/pull/982
M
Michaelabout 1 month ago
Would I be able to get a review on this PR that adds the ability to
https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/145
copy_tags_to_snapshots for DocumentDB?https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/145
M
Michaelabout 1 month ago
Would I be able to get a review on configuration support for the desync mitigation mode on the ALBs?
https://github.com/cloudposse/terraform-aws-alb/pull/206
https://github.com/cloudposse/terraform-aws-alb/pull/206
J
Jonathan Roseabout 1 month ago
@Erik Osterman (Cloud Posse) lmk when I can test Fix: INLINECODE_0 fails with "failed to find import" when base ref has no stack files by Copilot · Pull Request #2185 · cloudposse/atmos 🙂
I
Ivan Pinattiabout 1 month ago
Hello, could please someone reopen and approve this PR please? It was waiting approval and was automatically closed.
• https://github.com/cloudposse-terraform-components/aws-aurora-mysql/pull/59
• https://github.com/cloudposse-terraform-components/aws-aurora-mysql/pull/59
R
R
RBabout 1 month ago
Please also review upgrading node runtime to node24 in github-action-pre-commit repo
https://github.com/cloudposse/github-action-pre-commit/pull/32/changes
https://github.com/cloudposse/github-action-pre-commit/pull/32/changes
R
RBabout 1 month ago(edited)
Please review updating gha atmos affected stacks
• ✅️Fix test and dep upgrade https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/82/changes
• ✅️fix injection points https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/85/changes
• dep upgrades
◦ ⏳️aws-actions/configure v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/81/changes
◦ ✅️setup-node v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/76/changes
• ✅️renovate best practices https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/67/changes
• ✅️Fix test and dep upgrade https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/82/changes
• ✅️fix injection points https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/85/changes
• dep upgrades
◦ ⏳️aws-actions/configure v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/81/changes
◦ ✅️setup-node v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/76/changes
• ✅️renovate best practices https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/67/changes
R
RBabout 2 months ago
S
Sean Nguyenabout 2 months ago(edited)
The datadog
@johncblandii
https://github.com/cloudposse/terraform-datadog-platform/pull/125
monitors submodule is not compatible with the latest release of the DataDog Terraform provider.@johncblandii
https://github.com/cloudposse/terraform-datadog-platform/pull/125
R
RBabout 2 months ago
Please review atmos security updates https://github.com/cloudposse/atmos/pull/2123
R
RBabout 2 months ago
Please review setting default instance type for all redis clusters
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/82
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/82
R
RBabout 2 months ago
Please also review bumping the minimum aws provider for the elasticache redis component https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/81
R
RBabout 2 months ago
Please review adding global engine_version default for all redis clusters https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/80
R
RBabout 2 months ago
Please review allowing dns_subdomain to be overridden per cluster in redis clusters https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/79
A
aaireyabout 2 months ago
Hi can anyone please review:
• https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/81
• https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/81
R
R
R
RBabout 2 months ago
Expose the rest of elasticache redis inputs
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/68
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/68
I
Ivan Pinattiabout 2 months ago
Another one, expose
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
num_shards and replicas_per_shard as component-level variables• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
I
Ivan Pinattiabout 2 months ago
One more PR, now to enable Slow and Engine logs options for Redis
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/
I
Ivan Pinattiabout 2 months ago
PR adding maintenance and snapshot window options for Elasticache Redis
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/64
• https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/64
I
Ivan Pinatti2 months ago
R
RB2 months ago
Another set of eyes here pleae https://github.com/cloudposse/terraform-aws-dynamodb/pull/141
J
Jakub Wądołowski2 months ago
I've just created two straightforward PRs that add
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
response_completion_timeout support to both CDN modules:• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
R
RB2 months ago
Please review setting bucket key to true default https://github.com/cloudposse/terraform-aws-s3-bucket/pull/285