pr-reviews
2992,913
Pull Request Reviews for Cloud Posse Projects
I
Ivan Pinattiabout 6 hours ago
R
RB2 days ago
Another set of eyes here pleae https://github.com/cloudposse/terraform-aws-dynamodb/pull/141
J
Jakub Wądołowski6 days ago
I've just created two straightforward PRs that add
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
response_completion_timeout support to both CDN modules:• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
R
RB7 days ago
Please review setting bucket key to true default https://github.com/cloudposse/terraform-aws-s3-bucket/pull/285
J
Jakub Wądołowski8 days ago
a small enhancement for the ECS web app module: https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/305. Would appreciate a review when you get a chance
D
david8 days ago
May I get a review please https://github.com/cloudposse-terraform-components/aws-api-gateway-rest-api/pull/46
M
Michael9 days ago
Sorry, quick patch fix for Datadog tags in the EKS agent: https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/75
M
MP13 days ago
Hello 👋
Would I be able to get a review for this PR => https://github.com/cloudposse/atmos/pull/2058 ?
Reference: https://sweetops.slack.com/archives/C031919U8A0/p1770405166302539
Would I be able to get a review for this PR => https://github.com/cloudposse/atmos/pull/2058 ?
Reference: https://sweetops.slack.com/archives/C031919U8A0/p1770405166302539
M
Michael14 days ago
Small PR fix for Cognito component's failing validation: https://github.com/cloudposse-terraform-components/aws-cognito/pull/50
M
Michael16 days ago
Small PR for fixing a Datadog tag parsing misinterpretation: https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/74
R
RB20 days ago
Please review changes to https://github.com/cloudposse-terraform-components/aws-account-settings/pull/52/files
M
Michael22 days ago
Would I be able to get a review on this bug fix? The change ensures that the validation conditions correctly handle
https://github.com/cloudposse-terraform-components/aws-cloudtrail-bucket/pull/56
null values by using a ternary operator instead of relying on logical OR, which can help avoid issues with type coercion.https://github.com/cloudposse-terraform-components/aws-cloudtrail-bucket/pull/56
I
Ivan Pinatti27 days ago
Could I get one more review? ECS Component Naming fix
• https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/pull/79
• https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/pull/79
I
Ivan Pinatti27 days ago
Hello everyone, happy Friday!
Could I get an approval for this PR? Finer Controls for S3 Events Notifications;
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/76
Could I get an approval for this PR? Finer Controls for S3 Events Notifications;
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/76
B
Bruce27 days ago
bumping default python version on datadog-lambda-forwarder like the module:
https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/91
https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/91
C
Cilas Beltrameabout 1 month ago
just re-pinging this again
N
Nitinabout 2 months ago
Hello everyone, can you please review this PR
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
B
Bruce2 months ago
client vpn component broke after latest update:
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
M
Marat Bakeev2 months ago
Hi everyone, can you please review this PR - https://github.com/cloudposse-terraform-components/aws-eks-alb-controller-ingress-class/pull/50
M
Michael2 months ago
May I get a review on this Geodesic PR? https://github.com/cloudposse/geodesic/pull/980
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
array=($(command)) with the more robust mapfile -t array < <(command) syntax- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
T
Tyler Rankin2 months ago
Irregular contributor here 👋
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
/test that need to be made. Thanks!https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
D
david2 months ago
May I get a review on this SQS -> Lambda trigger please https://github.com/cloudposse-terraform-components/aws-lambda/pull/44
E
Y
Yevdokiia Mazhak3 months ago
hello!
anyone that can have a look at https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/162?
anyone that can have a look at https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/162?
T
Tomasz Głuch3 months ago
Hi folks,
could I ask you to review https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/96? This change isn't mine, but I've been testing it recently and it works great. The current version of this module has one simple but serious drawback that makes it difficult to use in a real environment.
could I ask you to review https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/96? This change isn't mine, but I've been testing it recently and it works great. The current version of this module has one simple but serious drawback that makes it difficult to use in a real environment.
M
Michael3 months ago
Would I be able to get a review on changing the Helm provider version constraint from
for the EKS Datadog Agent component?
https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/69
>= 2.7 to ~> 2.7for the EKS Datadog Agent component?
https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/69
M
Michael3 months ago
Can I get a PR review on this Elasticsearch component improvement? This introduces new configuration options and refactors how key variables are set and passed to the Elasticsearch module. The main focus is on improving flexibility for domain and subdomain naming, advanced security options, and storage configuration, while making these options configurable via input variables
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
N
Nitin3 months ago
Hi, i just added dualstack support in the aws efs repo. can i get review on the PR
https://github.com/cloudposse/terraform-aws-efs/pull/163
https://github.com/cloudposse/terraform-aws-efs/pull/163
M
Musthaq3 months ago
Hi,
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
B
Bruce3 months ago
adding userdata and enhanced monitoring to karpenter ec2 node class
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/52
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/52
Michael3 months ago
Would I be able to get a review on this Elasticsearch component updates that introduces new configuration options and refactors how key variables are set and passed to the Elasticsearch module?
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
Musthaq3 months ago
Hi,
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
Michael3 months ago
Could I please get a review for adding a new output
https://github.com/cloudposse-terraform-components/aws-alb/pull/53
certificate_arn for the ALB component?https://github.com/cloudposse-terraform-components/aws-alb/pull/53
Jan Costandius4 months ago(edited)
Miniature PR for the ALB module. https://github.com/cloudposse/terraform-aws-alb/pull/205
Adil Sadik4 months ago
👋 hi folks! could i please get a review on https://github.com/cloudposse/terraform-aws-waf/pull/128? This adds support for custom responses to size constraint rules, which will close out https://github.com/cloudposse/terraform-aws-waf/issues/95
Colin Hughes4 months ago
Hello! Could I get a review on this PR? It updates a deprecation in v6 of the AWS Provider. https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/252
Cilas Beltrame4 months ago
can I get a review on this PR pls? The idea behind it is to expose the suffix for lifecycle role (Beanstalk) to be overwritten
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-application/pull/61
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-application/pull/61
Yangci Ou4 months ago
Can I get a review on this PR, to add tags from the context to Listener Rule resources in the
terraform-aws-alb-ingress module? (The target group resources in this module already has tags) https://github.com/cloudposse/terraform-aws-alb-ingress/pull/100Michael4 months ago
• Would I be able to get a review on this one as well? This introduces support for AWS OpenSearch domains alongside Elasticsearch, adds SAML authentication options, and improves configuration flexibility and output handling. The changes allow users to choose between deploying Elasticsearch or OpenSearch in the component
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/64
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/64
Michael4 months ago(edited)
• Would I be able to get a review on this PR? Previously, service domain output locals were always set, even when the module was disabled. This caused issues with downstream components. Now, these locals are set to null when the module is not enabled, preventing unintended values and improving conditional logic handling.
https://github.com/cloudposse/terraform-aws-elasticsearch/pull/216
https://github.com/cloudposse/terraform-aws-elasticsearch/pull/216
Yangci Ou4 months ago
• Supporting
• Fix tests in the
database_insights_mode in RDS (they are sunsetting Performance Insights in favor of Database Insights): https://github.com/cloudposse/terraform-aws-rds-cluster/pull/274• Fix tests in the
terrafrom-aws-ecs-alb-service-task module (by upgrading the examples/complete subnets module): https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/272Quixotical4 months ago
Can I get a review for a small change to AWS DMS Replication Instance module? This makes the DMS subnet group optional (but creates it by default to maintain backwards compatibility) and allows you to specify a DMS subnet group ID for the replication instance to use:
https://github.com/cloudposse/terraform-aws-dms/pull/43
https://github.com/cloudposse/terraform-aws-dms/pull/43
Yangci Ou4 months ago(edited)
Small PR in the MQ brokers module to allow provisioning SSM parameters as optional. Currently consumers of this module is forced to always create SSM parameters. https://github.com/cloudposse/terraform-aws-mq-broker/pull/109
• There are cases where consumers don't want to use SSM parameters, such as using alternative secrets management.
• This is fully backwards compatible since there are already existing
• Closes issue https://github.com/cloudposse/terraform-aws-mq-broker/issues/68
• There are cases where consumers don't want to use SSM parameters, such as using alternative secrets management.
• This is fully backwards compatible since there are already existing
count in place, and by default, it works exactly like before to create the SSM param.• Closes issue https://github.com/cloudposse/terraform-aws-mq-broker/issues/68
Michael4 months ago
Can I also get a review on this PR that introduces support for allowing AWS RDS to manage the admin user password for Aurora PostgreSQL clusters via Secrets Manager, while maintaining backward compatibility with the existing manual password management:
https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/64
https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/64
Michael4 months ago
Can I also get another review on this PR that supports specifying
https://github.com/cloudposse-terraform-components/aws-eks-external-secrets-operator/pull/45
parameter_store_paths and resources in the values passed to the external_ssm_secrets component?https://github.com/cloudposse-terraform-components/aws-eks-external-secrets-operator/pull/45
Michael4 months ago
Can I get a review on this PR that adds support for AWS managed master passwords in the DocumentDB component? We have been running this customization for a few months now: https://github.com/cloudposse-terraform-components/aws-documentdb/pull/52
Michael5 months ago
Here's a small PR that cleans up the Opsgenie component by removing the legacy syntax and unused vars: https://github.com/cloudposse-terraform-components/aws-opsgenie-team/pull/53
Yangci Ou5 months ago
PR to fix tests in the AWS Brokers (ActiveMQ/RabbitMQ) module by updating the
examples/complete to use latest version of the subnets module and update engine version: https://github.com/cloudposse/terraform-aws-mq-broker/pull/108M5 months ago(edited)
would someone be able to start tests on https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/279? thank you in advance
Kamil Grabowski5 months ago
Hello,
I created a new PR that adds CPU options parameters to EC2 Autoscaling Group module: https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/159 This will allow us to disable SMP/Intel Hyper-Threading for CPU Intensive workloads. Could you please review it?
I created a new PR that adds CPU options parameters to EC2 Autoscaling Group module: https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/159 This will allow us to disable SMP/Intel Hyper-Threading for CPU Intensive workloads. Could you please review it?