pr-reviews
2993,477
Pull Request Reviews for Cloud Posse Projects
Ivan Pinattiabout 1 hour ago
Hello, could I get a review please?
β’ github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/123 - Adds
β’ github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/123 - Adds
query_exclusions so an archive can drop a class of logs, like health checks, without restating the whole query, and applies it to the catchall archive too.U
U0C5H0X7E1Labout 10 hours ago
Iβm researching how teams handle several PRs that are individually green but
need to ship together. How do you validate merge order, interactions between
changes and affected tests without repeatedly running the full CI suite? Iβd
be interested in how teams with high PR throughput approach this.
need to ship together. How do you validate merge order, interactions between
changes and affected tests without repeatedly running the full CI suite? Iβd
be interested in how teams with high PR throughput approach this.
Ivan Pinatti2 days ago(edited)
Hello, could I get a review on this PR please?
β’ github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.
β’ github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.
Ivan Pinatti6 days ago
Hey, could I please get a review on this one?
β’ github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
β’ github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
Ivan Pinatti7 days ago
Could I get a review please?
β’ github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks
β’ github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks
aws-datadog-monitor, where terraform init and terraform validate both fail on main todayMichael7 days ago
If anyone has a chance to review, this adds some SSM functions to the test-helpers package. When we build an AMI with Packer, we use Terraform, Terratest, and SSM to run host checks to ensure it's configured as we intend. Contributing these back to the community for other's use could be beneficial for reusability
github.com/cloudposse/test-helpers/pull/99
github.com/cloudposse/test-helpers/pull/99
PePe Amengual8 days ago
this is ready for review https://github.com/cloudposse/terraform-aws-ipam/pull/3
PePe Amengual8 days ago(edited)
any reason why the IPAM component used https://github.com/aws-ia/terraform-aws-ipam instead of a cloudposse managed module? last release of the AWS maintained module is a year old, are you guys open on creating a cloudposse owned module? ( I have cycles and interest)
Ivan Pinatti9 days ago
Please could I get a review on this PR?
β’ github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
β’ github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
Ivan Pinatti12 days ago
Happy Friday! The last PR for this week, could I please get a review?
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including
cluster_parameter_group_family which RA3/RG clusters needIvan Pinatti13 days ago
Could I also get a review on this PR please?
β’ github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
β’ github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
Ivan Pinatti13 days ago(edited)
Could I please get an approval review on these two Renovate PRs? Both are green and just blocked on
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/55
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/46
REVIEW_REQUIRED.β’ github.com/cloudposse-terraform-components/aws-redshift/pull/55
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/46
PePe Amengual14 days ago
If I could gets some eyes on https://github.com/cloudposse-terraform-components/aws-config/pull/69
Ivan Pinatti15 days ago
Please could I get a review on this PR?
β’ github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard
β’ github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard
domain_nameBen Smith (Benbentwo)16 days ago
One tiny PR for EKS Cluster module github.com/cloudposse/terraform-aws-eks-cluster/pull/266
Ben Smith (Benbentwo)16 days ago
Small pr for EKS Cluster github.com/cloudposse-terraform-components/aws-eks-cluster/pull/95
Ivan Pinatti16 days ago(edited)
Could I please get a review on these 4 PRs?
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period
Two small things that would help:
β’ The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period
Two small things that would help:
β’ The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
Ivan Pinatti19 days ago
Another PR, unrelated with the previous ones. Could I please also get a review?
β’ github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
β¦ Changes the archive bucket lifecycle default from
β’ github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
β¦ Changes the archive bucket lifecycle default from
GLACIER to GLACIER_IR. Datadog can't read GLACIER for rehydration or Archive Search, so on the default config the archive silently becomes unreadable a year after the first object lands.Ivan Pinatti19 days ago
One more PR, this is a bug in the ssm path, easy review.
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/51
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/51
Ivan Pinatti20 days ago(edited)
Could I please get a review on these 3 PRs?
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/50
β¦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/49
β¦ Removes an output that no longer exists on the wrapped module
β’ github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
β¦ Makes the parameter group family configurable so RA3/RG clusters can be managede
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/50
β¦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
β’ github.com/cloudposse-terraform-components/aws-redshift/pull/49
β¦ Removes an output that no longer exists on the wrapped module
β’ github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
β¦ Makes the parameter group family configurable so RA3/RG clusters can be managede
Michal Tomaszek20 days ago
Could someone review this version pinning PR?
github.com/cloudposse/github-action-matrix-extended/pull/25
github.com/cloudposse/github-action-matrix-extended/pull/25
Ben Smith (Benbentwo)22 days ago
github.com/cloudposse/terraform-aws-s3-log-storage/pull/141 looks a little stuck -
/terratest looks to have run for some checks but not all - @Andriy Knysh (Cloud Posse) if you get a moment could you take a lookMichaelabout 1 month ago
One more (small) AWS Backup improvement for supporting
schedule_expression_timezoneif anyone has a chance to review:github.com/cloudposse/terraform-aws-backup/pull/109Michaelabout 1 month ago
If anyone has a chance to review this, it adds to ability to
force_destroy on the AWS Backup Vault: github.com/cloudposse/terraform-aws-backup/pull/108Ihor Urazovabout 2 months ago
davidabout 2 months ago
may I get a review on github.com/cloudposse/terraform-aws-waf/pull/133 please
Ivan Pinattiabout 2 months ago
This PR is from Renovate and is stuck, someone could review and unblock it please?
β’ github.com/cloudposse-terraform-components/aws-waf/pull/73
β’ github.com/cloudposse-terraform-components/aws-waf/pull/73
Michal Tomaszekabout 2 months ago
Hey, follow-up of yesterday's PR:
github.com/cloudposse-terraform-components/aws-github-repository/pull/60
github.com/cloudposse-terraform-components/aws-github-repository/pull/60
MPabout 2 months ago
Hello, could you review this PR ? github.com/cloudposse/atmos/pull/2914
Here is the issue as well => github.com/cloudposse/atmos/issues/2913
Here is the issue as well => github.com/cloudposse/atmos/issues/2913
Michal Tomaszekabout 2 months ago
Hey, could you review this PR for
github.com/cloudposse/terraform-github-repository/pull/32
terraform-github-repository ?github.com/cloudposse/terraform-github-repository/pull/32
Jonathanabout 2 months ago(edited)
Hello, the following PRs are ready for (re)review:
β’ github.com/cloudposse/atmos/pull/2820
β’ github.com/cloudposse/atmos/pull/2835
β’ github.com/cloudposse/atmos/pull/2833
β’ github.com/cloudposse/atmos/pull/2832
β’ github.com/cloudposse/atmos/pull/2820
β’ github.com/cloudposse/atmos/pull/2835
β’ github.com/cloudposse/atmos/pull/2833
β’ github.com/cloudposse/atmos/pull/2832
Seanabout 2 months ago
Hello, github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/69 has been created to bring the defaults & functionality in line with the current cert-manager while providing the ability to retain older version behaviors if desired
Michael2 months ago
Would I be able to get one more PR review on this EKS feature?
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Jonathan2 months ago
Hi @Erik Osterman (Cloud Posse) let me know if you need anything else for https://github.com/cloudposse/atmos/pull/2820
david2 months ago
may I get a review please to allow for
not_resources in SCPs? github.com/cloudposse/terraform-aws-service-control-policies/pull/71Ivan Pinatti2 months ago
Two more PRs, this is to address a specific scenario using these component.
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
β’ github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
β’ github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
β’ github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
β’ github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Ivan Pinatti2 months ago
Hi everyone, could I get a review on this PR please? It is a bug fix.
β’ github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
β’ github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
β’ github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
β’ github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ben Smith (Benbentwo)2 months ago(edited)
affected by the
cloudposse/utils: no available releases match the given constraints
>= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0problem
Ben Smith (Benbentwo)2 months ago(edited)
S3 Bucket update to latest module + provider
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
Ben Smith (Benbentwo)2 months ago
Can i get a reveiw on github.com/cloudposse/terraform-aws-s3-bucket/pull/295
Marat Bakeev2 months ago
Could anyone have a look at this PR for removing account-map dependency? github.com/cloudposse-terraform-components/aws-spa-s3-cloudfront/pull/68
Alex Renoki3 months ago
Hi there, I eventually realized there is a lot on the plate for yβall and donβt see the GH notifications. π
Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the
Just so I know if I should close the PR and wait for the above PR to be finished.
Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the
atmos stack schema command (github.com/cloudposse/atmos/commit/0485a62a5c75β¦, github.com/cloudposse/atmos/pull/2761)Just so I know if I should close the PR and wait for the above PR to be finished.
Ivan Pinatti3 months ago
Hey guys, I know you all have been busy. When you can, could someone please review these PRs? I shared them a while ago, but they have not been reviewed yet. They are mostly AWS Utils 2.x bumps and a few minor bug fixes.
β’ github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
β’ github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
β’ github.com/cloudposse-terraform-components/aws-teams/pull/65
β’ github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
β’ github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
β’ github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for
β’ github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7β¦
β’ github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
β’ github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
β’ github.com/cloudposse-terraform-components/aws-teams/pull/65
β’ github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
β’ github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
β’ github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for
aws-aurora-mysql was merged into main, but no release has been cut since then, could someone please cut a version so we can vendor it?β’ github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7β¦
PePe Amengual3 months ago
https://github.com/cloudposse-terraform-components/aws-managed-grafana-workspace/pull/56 @Andriy Knysh (Cloud Posse)