pr-reviews
2993,350
Pull Request Reviews for Cloud Posse Projects
Michael1 day ago
Would I be able to get one more PR review on this EKS feature?
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Jonathan1 day ago
Hi @Erik Osterman (Cloud Posse) let me know if you need anything else for https://github.com/cloudposse/atmos/pull/2820
david2 days ago
may I get a review please to allow for
not_resources in SCPs? github.com/cloudposse/terraform-aws-service-control-policies/pull/71Ivan Pinatti4 days ago
Two more PRs, this is to address a specific scenario using these component.
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
• github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
• github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Ivan Pinatti9 days ago
Hi everyone, could I get a review on this PR please? It is a bug fix.
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ben Smith (Benbentwo)9 days ago(edited)
affected by the
cloudposse/utils: no available releases match the given constraints
>= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0problem
Ben Smith (Benbentwo)10 days ago(edited)
S3 Bucket update to latest module + provider
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
Ben Smith (Benbentwo)11 days ago
Can i get a reveiw on github.com/cloudposse/terraform-aws-s3-bucket/pull/295
Marat Bakeev11 days ago
Could anyone have a look at this PR for removing account-map dependency? github.com/cloudposse-terraform-components/aws-spa-s3-cloudfront/pull/68
Alex Renoki15 days ago
Hi there, I eventually realized there is a lot on the plate for y’all and don’t see the GH notifications. 😅
Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the
Just so I know if I should close the PR and wait for the above PR to be finished.
Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the
atmos stack schema command (github.com/cloudposse/atmos/commit/0485a62a5c75…, github.com/cloudposse/atmos/pull/2761)Just so I know if I should close the PR and wait for the above PR to be finished.
Ivan Pinatti16 days ago
Hey guys, I know you all have been busy. When you can, could someone please review these PRs? I shared them a while ago, but they have not been reviewed yet. They are mostly AWS Utils 2.x bumps and a few minor bug fixes.
• github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
• github.com/cloudposse-terraform-components/aws-teams/pull/65
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
• github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for
• github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7…
• github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
• github.com/cloudposse-terraform-components/aws-teams/pull/65
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
• github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for
aws-aurora-mysql was merged into main, but no release has been cut since then, could someone please cut a version so we can vendor it?• github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7…
PePe Amengual17 days ago
https://github.com/cloudposse-terraform-components/aws-managed-grafana-workspace/pull/56 @Andriy Knysh (Cloud Posse)
PePe Amengual17 days ago
what is the latest to the Utils module problem? https://github.com/cloudposse-terraform-components/aws-managed-grafana-workspace/actions/runs/25477300111/job/74753457841?pr=53 what can I do to fix that?
PePe Amengual17 days ago
PR to add severity filters to https://github.com/cloudposse/terraform-aws-security-hub/pull/79
Michael18 days ago
Small PR for adding
iam_role_arn to the CloudFormation stack module: github.com/cloudposse/terraform-aws-cloudformation-stack/pull/39Chris Harden22 days ago
The acceptance test for windows timed out. Will you please fire it off again?
Ivan Pinatti23 days ago
PR fixing a bug, when possible, could I get a review/approval?
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Chris Harden23 days ago
Ivan Pinatti30 days ago
Could I please get a review on this PR? github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
Chris Harden30 days ago
Can I get a "Approve and run workflows" on github.com/cloudposse/atmos/pull/2674
Thanks!!
Thanks!!
Ivan Pinattiabout 1 month ago
---
Another PR for review please;
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
Another PR for review please;
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
Michaelabout 1 month ago
Would I be able to get a review on this PR that fixes the failing tests for the Redshift module? Had to update some of the outdated test values and migrate the
github.com/cloudposse/terraform-aws-redshift-cluster/pull/49
logging configuration to the new resource, but everything should be backwards compatible and included in the tests:github.com/cloudposse/terraform-aws-redshift-cluster/pull/49
davidabout 1 month ago
may I get a review please github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ivan Pinattiabout 1 month ago
Could I get a pair of eyes on this PR please?
• github.com/cloudposse-terraform-components/aws-teams/pull/65
remote-state 1.8.0 → 2.0.0 for utils 2.x compatibility• github.com/cloudposse-terraform-components/aws-teams/pull/65
Marat Bakeevabout 1 month ago(edited)
Can this PR get reviewed? github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
Allows to hide ArgoCD on internal alb and only expose webhooks
Allows to hide ArgoCD on internal alb and only expose webhooks
davidabout 1 month ago
may we get this old PR reviewed please, github.com/cloudposse/terraform-aws-waf/pull/130? It adds some functionality we are looking for. I can followup with a PR on the component as well
Michaelabout 1 month ago
Would I be able to get a small PR review to add the
hosted_zone_id output to the bucket module? github.com/cloudposse/terraform-aws-s3-bucket/pull/293Brianabout 1 month ago
https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this
atmos secret list -s <stack> against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.Marat Bakeevabout 1 month ago
Hi guys, somewhat large bump to cognito component - https://github.com/cloudposse-terraform-components/aws-cognito/pull/63
Let me know if this is not acceptable.
Let me know if this is not acceptable.
Marat Bakeevabout 2 months ago
A small PR to add support for using local instance store disks in karpenter node pools - https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/73
Michaelabout 2 months ago
Not sure if the team would have any interest in this but it adds support for govcloud AWS accounts: https://github.com/cloudposse-terraform-components/aws-account/pull/56
Marat Bakeevabout 2 months ago
Hey 👋 Opened a small bug-fix PR for the atmos ansible playbook command: https://github.com/cloudposse/atmos/pull/2594
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
ansible-playbook flags through.Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Michaelabout 2 months ago
Could I get a review of this change that fixes some tflint findings, typos, and adds support for
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
force_update_version and control_plane_scaling_config for the EKS module?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Quentin BERTRANDabout 2 months ago
Hi Clouders!
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
Miguel Zablahabout 2 months ago
PR to update module to AWS v6 and also update some modules:
https://github.com/cloudposse/terraform-aws-config/pull/141
https://github.com/cloudposse/terraform-aws-config/pull/141
Michael2 months ago
Small PR after running tflint on the s3 bucket module: https://github.com/cloudposse-terraform-components/aws-s3-bucket/pull/82
Jonathan2 months ago
May I get reviews please?
https://github.com/cloudposse/atmos/pull/2549
https://github.com/cloudposse/atmos/pull/2548
https://github.com/cloudposse/atmos/pull/2547
https://github.com/cloudposse/atmos/pull/2549
https://github.com/cloudposse/atmos/pull/2548
https://github.com/cloudposse/atmos/pull/2547
PePe Amengual2 months ago
Jonathan2 months ago
May I get reviews?
https://github.com/cloudposse/atmos/pull/2541
https://github.com/cloudposse/atmos/pull/2540
https://github.com/cloudposse/atmos/pull/2541
https://github.com/cloudposse/atmos/pull/2540
Ben Smith (Benbentwo)2 months ago
I have a relatively simple PR https://github.com/cloudposse-terraform-components/aws-managed-grafana-dashboard/pull/47 (new var input directly into resource) it fails with the issue of
do you want a new PR to update to Remote-state 2.0.0? Same PR? seems like this is an issue across many components, perhaps the range
│ Could not retrieve the list of available versions for provider
│ cloudposse/utils: no available releases match the given constraints >=
│ 0.3.0, >= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0do you want a new PR to update to Remote-state 2.0.0? Same PR? seems like this is an issue across many components, perhaps the range
>= 1.7.1, < 3.0.0 would work (more forgiving for 2.X.Y releases that IIRC didn't have breaking changes)PePe Amengual2 months ago
Hi CP I have a PR for review https://github.com/cloudposse/terraform-aws-transit-gateway/pull/67 to add
asn to the TGW componentArnoldas Brazys2 months ago
Hi team,
datadog integration been dragging with deprecation warnings since v2, now v4 already available, who could look into it?
https://github.com/cloudposse/terraform-aws-datadog-integration/pull/73
datadog integration been dragging with deprecation warnings since v2, now v4 already available, who could look into it?
https://github.com/cloudposse/terraform-aws-datadog-integration/pull/73