pr-reviews
2993,217
Pull Request Reviews for Cloud Posse Projects
Brianabout 15 hours ago
https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this
atmos secret list -s <stack> against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.Marat Bakeev2 days ago
Hi guys, somewhat large bump to cognito component - https://github.com/cloudposse-terraform-components/aws-cognito/pull/63
Let me know if this is not acceptable.
Let me know if this is not acceptable.
Marat Bakeev7 days ago
A small PR to add support for using local instance store disks in karpenter node pools - https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/73
Michael10 days ago
Not sure if the team would have any interest in this but it adds support for govcloud AWS accounts: https://github.com/cloudposse-terraform-components/aws-account/pull/56
Marat Bakeev11 days ago
Hey 👋 Opened a small bug-fix PR for the atmos ansible playbook command: https://github.com/cloudposse/atmos/pull/2594
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
ansible-playbook flags through.Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Michael12 days ago
Could I get a review of this change that fixes some tflint findings, typos, and adds support for
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
force_update_version and control_plane_scaling_config for the EKS module?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Quentin BERTRAND17 days ago
Hi Clouders!
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
Miguel Zablah18 days ago
PR to update module to AWS v6 and also update some modules:
https://github.com/cloudposse/terraform-aws-config/pull/141
https://github.com/cloudposse/terraform-aws-config/pull/141
Michael20 days ago
Small PR after running tflint on the s3 bucket module: https://github.com/cloudposse-terraform-components/aws-s3-bucket/pull/82
Jonathan21 days ago
May I get reviews please?
https://github.com/cloudposse/atmos/pull/2549
https://github.com/cloudposse/atmos/pull/2548
https://github.com/cloudposse/atmos/pull/2547
https://github.com/cloudposse/atmos/pull/2549
https://github.com/cloudposse/atmos/pull/2548
https://github.com/cloudposse/atmos/pull/2547
PePe Amengual23 days ago
Jonathan24 days ago
May I get reviews?
https://github.com/cloudposse/atmos/pull/2541
https://github.com/cloudposse/atmos/pull/2540
https://github.com/cloudposse/atmos/pull/2541
https://github.com/cloudposse/atmos/pull/2540
Ben Smith (Benbentwo)25 days ago
I have a relatively simple PR https://github.com/cloudposse-terraform-components/aws-managed-grafana-dashboard/pull/47 (new var input directly into resource) it fails with the issue of
do you want a new PR to update to Remote-state 2.0.0? Same PR? seems like this is an issue across many components, perhaps the range
│ Could not retrieve the list of available versions for provider
│ cloudposse/utils: no available releases match the given constraints >=
│ 0.3.0, >= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0do you want a new PR to update to Remote-state 2.0.0? Same PR? seems like this is an issue across many components, perhaps the range
>= 1.7.1, < 3.0.0 would work (more forgiving for 2.X.Y releases that IIRC didn't have breaking changes)PePe Amengual26 days ago
Hi CP I have a PR for review https://github.com/cloudposse/terraform-aws-transit-gateway/pull/67 to add
asn to the TGW componentArnoldas Brazys27 days ago
Hi team,
datadog integration been dragging with deprecation warnings since v2, now v4 already available, who could look into it?
https://github.com/cloudposse/terraform-aws-datadog-integration/pull/73
datadog integration been dragging with deprecation warnings since v2, now v4 already available, who could look into it?
https://github.com/cloudposse/terraform-aws-datadog-integration/pull/73
erik28 days ago
@Igor Rodionov
Marat Bakeev28 days ago
N.B. - the pipeline seems unhappy
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider
│ cloudposse/utils: no available releases match the given constraints >=
│ 0.3.0, >= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0Marat Bakeev28 days ago
And another request - support for making ArgoCD internal, while still exposing its webhook receiver publicly.
https://github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
https://github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
Marat Bakeev28 days ago
Hi team, can someone have a look at this PR that adds support for custom MAIL FROM domain in the ses component?
https://github.com/cloudposse-terraform-components/aws-ses/pull/69
https://github.com/cloudposse-terraform-components/aws-ses/pull/69
Michael30 days ago
Would I be able to get a PR that adds
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/260
deletion_protection for EKS clusters?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/260
Jonathanabout 1 month ago(edited)
May I get reviews please?
• https://github.com/cloudposse/atmos/pull/2477
• https://github.com/cloudposse/atmos/pull/2478
• https://github.com/cloudposse/atmos/pull/2477
• https://github.com/cloudposse/atmos/pull/2478
Jonathanabout 1 month ago
May I get a review of https://github.com/cloudposse/atmos/pull/2430 please?
Tyrone Meijnabout 1 month ago
Hi 👋 I submitted a fix for the classic plan time for_each issue: https://github.com/cloudposse/terraform-aws-iam-role/pull/92
Jakub Wądołowskiabout 1 month ago
hey! I just submitted a minor monitoring improvement to both
• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/162
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/372
cloudposse/cloudfront-cdn/aws and cloudposse/cloudfront-s3-cdn/aws modules:• https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/162
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/372
Josh Simmondsabout 1 month ago
👋 Hi friends! PR here to bolster the native CI rewrite and fix issue 2367 (native CI not posting to PRs): https://github.com/cloudposse/atmos/pull/2405
Ben Smith (Benbentwo)about 1 month ago
Could i get a review on https://github.com/cloudposse-terraform-components/aws-iam-role/pull/64
Ivan Pinattiabout 2 months ago
Could I please get an approval for this bugfix?
https://github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/51
https://github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/51
Michaelabout 2 months ago
If anyone has a chance, this adds some additional parameters to the VPC flow logs in the
vpc component: https://github.com/cloudposse-terraform-components/aws-vpc/pull/93PePe Amengualabout 2 months ago
continuation of the fixes https://github.com/cloudposse/terraform-aws-sso/pull/77
PePe Amengualabout 2 months ago
Please take a look https://github.com/cloudposse-terraform-components/aws-identity-center/pull/74 thanks
Quentin BERTRAND2 months ago
PR to add
feat: add bucket_namespace argument
bucket_namespace to allow regional namespace usage in terraform-aws-s3-bucket modulefeat: add bucket_namespace argument
Michal Tomaszek2 months ago
PR to improve importing of environments in repositories:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/50
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/50
Michal Tomaszek2 months ago
PR for component to handle webhook secret as a sensitive data:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/49
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/49
Michal Tomaszek2 months ago
PR for handling webhook secret as a sensitive data:
https://github.com/cloudposse/terraform-github-repository/pull/28
https://github.com/cloudposse/terraform-github-repository/pull/28
Michal Tomaszek2 months ago
Hey, could you check this one?
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/48
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/48
Ivan Pinatti2 months ago
Hello, could I get a pair of eyes and approval on these two PRs please? One was already approved but failed the tests and now it is corrected.
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/92
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/92
• https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
Stanislava Racheva2 months ago(edited)
Hello everyone, would someone please review https://github.com/cloudposse/terraform-aws-rds-cluster/pull/282
Its about making the random pet name suffix optional which prevents rds instances re-creation.
@Igor Rodionov @Joe Niland would you please take a look when you have some time, very much appreciated!
Its about making the random pet name suffix optional which prevents rds instances re-creation.
@Igor Rodionov @Joe Niland would you please take a look when you have some time, very much appreciated!
Jonathan2 months ago
Michael2 months ago
A follow up PR to add blue green updates to the RDS component as well: https://github.com/cloudposse-terraform-components/aws-rds/pull/65
Michael2 months ago
If anyone has a chance to review, this adds support for blue green updates to the RDS module:
https://github.com/cloudposse/terraform-aws-rds/pull/206
https://github.com/cloudposse/terraform-aws-rds/pull/206
Michal Tomaszek2 months ago
Michal Tomaszek2 months ago
And one for
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/41
aws-github-repository root module - missing field:https://github.com/cloudposse-terraform-components/aws-github-repository/pull/41
Michal Tomaszek2 months ago
Hi, another PR for
https://github.com/cloudposse/terraform-github-repository/pull/23
terraform-github-repository module to make it more flexible;https://github.com/cloudposse/terraform-github-repository/pull/23
Michal Tomaszek2 months ago
Hey, could you review this one, too?:
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/40
https://github.com/cloudposse-terraform-components/aws-github-repository/pull/40
Ivan Pinatti2 months ago
Could I get some eyes and approval on this PR please?
https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
https://github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/69
Michal Tomaszek2 months ago(edited)
Hi, could you review this PR? - a small fix:
https://github.com/cloudposse/terraform-github-repository/pull/22
https://github.com/cloudposse/terraform-github-repository/pull/22