14 messages
Pull Request Reviews for Cloud Posse Projects
Kamil Grabowski5 months ago
Hello,
I created a new PR that adds CPU options parameters to EC2 Autoscaling Group module: https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/159 This will allow us to disable SMP/Intel Hyper-Threading for CPU Intensive workloads. Could you please review it?
I created a new PR that adds CPU options parameters to EC2 Autoscaling Group module: https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/159 This will allow us to disable SMP/Intel Hyper-Threading for CPU Intensive workloads. Could you please review it?
M5 months ago(edited)
would someone be able to start tests on https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/279? thank you in advance
Yangci Ou5 months ago
PR to fix tests in the AWS Brokers (ActiveMQ/RabbitMQ) module by updating the
examples/complete to use latest version of the subnets module and update engine version: https://github.com/cloudposse/terraform-aws-mq-broker/pull/108Michael5 months ago
Here's a small PR that cleans up the Opsgenie component by removing the legacy syntax and unused vars: https://github.com/cloudposse-terraform-components/aws-opsgenie-team/pull/53
Michael4 months ago
Can I get a review on this PR that adds support for AWS managed master passwords in the DocumentDB component? We have been running this customization for a few months now: https://github.com/cloudposse-terraform-components/aws-documentdb/pull/52
Michael4 months ago
Can I also get another review on this PR that supports specifying
https://github.com/cloudposse-terraform-components/aws-eks-external-secrets-operator/pull/45
parameter_store_paths and resources in the values passed to the external_ssm_secrets component?https://github.com/cloudposse-terraform-components/aws-eks-external-secrets-operator/pull/45
Michael4 months ago
Can I also get a review on this PR that introduces support for allowing AWS RDS to manage the admin user password for Aurora PostgreSQL clusters via Secrets Manager, while maintaining backward compatibility with the existing manual password management:
https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/64
https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/64
Yangci Ou4 months ago(edited)
Small PR in the MQ brokers module to allow provisioning SSM parameters as optional. Currently consumers of this module is forced to always create SSM parameters. https://github.com/cloudposse/terraform-aws-mq-broker/pull/109
• There are cases where consumers don't want to use SSM parameters, such as using alternative secrets management.
• This is fully backwards compatible since there are already existing
• Closes issue https://github.com/cloudposse/terraform-aws-mq-broker/issues/68
• There are cases where consumers don't want to use SSM parameters, such as using alternative secrets management.
• This is fully backwards compatible since there are already existing
count in place, and by default, it works exactly like before to create the SSM param.• Closes issue https://github.com/cloudposse/terraform-aws-mq-broker/issues/68
Quixotical4 months ago
Can I get a review for a small change to AWS DMS Replication Instance module? This makes the DMS subnet group optional (but creates it by default to maintain backwards compatibility) and allows you to specify a DMS subnet group ID for the replication instance to use:
https://github.com/cloudposse/terraform-aws-dms/pull/43
https://github.com/cloudposse/terraform-aws-dms/pull/43
Yangci Ou4 months ago
• Supporting
• Fix tests in the
database_insights_mode in RDS (they are sunsetting Performance Insights in favor of Database Insights): https://github.com/cloudposse/terraform-aws-rds-cluster/pull/274• Fix tests in the
terrafrom-aws-ecs-alb-service-task module (by upgrading the examples/complete subnets module): https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/272Michael4 months ago(edited)
• Would I be able to get a review on this PR? Previously, service domain output locals were always set, even when the module was disabled. This caused issues with downstream components. Now, these locals are set to null when the module is not enabled, preventing unintended values and improving conditional logic handling.
https://github.com/cloudposse/terraform-aws-elasticsearch/pull/216
https://github.com/cloudposse/terraform-aws-elasticsearch/pull/216
Michael4 months ago
• Would I be able to get a review on this one as well? This introduces support for AWS OpenSearch domains alongside Elasticsearch, adds SAML authentication options, and improves configuration flexibility and output handling. The changes allow users to choose between deploying Elasticsearch or OpenSearch in the component
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/64
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/64
Yangci Ou4 months ago
Can I get a review on this PR, to add tags from the context to Listener Rule resources in the
terraform-aws-alb-ingress module? (The target group resources in this module already has tags) https://github.com/cloudposse/terraform-aws-alb-ingress/pull/100Cilas Beltrame4 months ago
can I get a review on this PR pls? The idea behind it is to expose the suffix for lifecycle role (Beanstalk) to be overwritten
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-application/pull/61
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-application/pull/61