16 messages
Pull Request Reviews for Cloud Posse Projects
K
Kiryl Kaminski7 months ago
Michael7 months ago
Would I be able to get a review on this WAF module improvement? It adds the ability to nest
not_statements for managed rules so you can control bot bypasses (https://github.com/cloudposse/terraform-aws-waf/pull/116)Bruce7 months ago
Looks like the datadog-logs-archive component is broken. i just opened a PR if someone could review:
https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/52
fix for: https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/issues/51
https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/52
fix for: https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/issues/51
Cilas Beltrame7 months ago
hey folks, raised a PR for
feat(): Avoid IAM service role name conflicts when used with terraform-aws-elastic-beanstalk-environment
Appreciate a review and feedback. Thanks!
terraform-aws-elastic-beanstalk-applicationfeat(): Avoid IAM service role name conflicts when used with terraform-aws-elastic-beanstalk-environment
Appreciate a review and feedback. Thanks!
Bruce7 months ago
allow SG reference when using transit gateway:
https://github.com/cloudposse/terraform-aws-transit-gateway/pull/64
https://github.com/cloudposse/terraform-aws-transit-gateway/pull/64
Michael6 months ago
Would I be able to get a review on adding this functionality to the WAF component which was recently introduced to the module? https://github.com/cloudposse-terraform-components/aws-waf/pull/40
Michael6 months ago
One more PR (for the day) to refactor some of the
manage_master_user_password logic in the DocumentDB module that is surfacing an output bug: https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/131Bruce6 months ago
would like to be able to configure lifecycle policies on the datadog-logs-archive rather than run the default. could someone take a look?
https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/54
https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/54
Geoff Hichborn6 months ago(edited)
Please review this enhancement to the documentdb module to support serverless: https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/132
Note that it likely requires a major version bump on the module since it raises the minimum AWS provider version (which itself has breaking changes).
Note that it likely requires a major version bump on the module since it raises the minimum AWS provider version (which itself has breaking changes).
Kiryl Kaminski6 months ago
Hello there!
Could you please review this pr when possible?
https://github.com/cloudposse/terraform-aws-budgets/pull/62
Will help to eliminate some deprecation warnings in budgets module
Could you please review this pr when possible?
https://github.com/cloudposse/terraform-aws-budgets/pull/62
Will help to eliminate some deprecation warnings in budgets module
David Becerra6 months ago
Hello there! Could you please help me with a review on this PR adding a new feature to the WAF module when possible?
https://github.com/cloudposse/terraform-aws-waf/pull/111
https://github.com/cloudposse/terraform-aws-waf/pull/111
Jan Costandius6 months ago
https://github.com/cloudposse/terraform-aws-eks-node-group/pull/221
I've uncommented the EKS Node Group tags for labels and taints for Cluster Autoscaler autodiscovery. The use case here is to allow CA to figure out which nodes it should use when scaling from 0.
I've uncommented the EKS Node Group tags for labels and taints for Cluster Autoscaler autodiscovery. The use case here is to allow CA to figure out which nodes it should use when scaling from 0.
Michael6 months ago
Could I get a review on adding
https://github.com/cloudposse-terraform-components/aws-cloudtrail/pull/43
log_group_class support to the Cloudtrail module for optimizing costs based on the access patterns of the logshttps://github.com/cloudposse-terraform-components/aws-cloudtrail/pull/43
Jakub Wądołowski6 months ago
here's a super simple PR that exposes underlying
docker_labels as a variable in the ECS web app module: https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/303Ian Cornett6 months ago
Hi all, I created a PR to address a bug in the ECS cluster module. I was fighting with iam_instance_profile when I was doing a fargate deployment and realized, I don't need instance profiles at all. This adds a check to the count to ensure that
length(var.capacity_providers_ec2) > 0 before creating the resource https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/71Kiryl Kaminski6 months ago(edited)
Hi there! Is there any chance someone could look at this renovate PR? Using aws provider v6 blocked for us because of vpc-endpoints submodule constraints:
https://github.com/cloudposse/terraform-aws-vpc/pull/159
https://github.com/cloudposse/terraform-aws-vpc/pull/159