#atmos-dev - November 2024

Hi team, this PR is good to review. Thank you!

https://github.com/cloudposse/atmos/pull/756

if you addressed PR comments, please ping me here for re-review (i don’t get notifications from GitHub when you mark a PR as ready for review)

Hi Team, this PR is good to review: https://github.com/cloudposse/atmos/pull/766

Thank you so much!

@Andriy Knysh (Cloud Posse) this is good for review https://github.com/cloudposse/atmos/pull/767

@Andriy Knysh (Cloud Posse) i think this is ready for final review https://github.com/cloudposse/atmos/pull/756

@Vinny please address outstanding comments in PRs so we can get them merged

this is a pain to fix found another more samples but the Flags: part is still not good
https://linear.app/cloudposse/issue/DEV-335/atmos-needs-to-wrap-long-lines-in-help

do you guys prefer that I leave the comments open and you close after checking the changes or should I resolve it once I send the fixes to clean up the PR?

good to review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/770
no docs to review only design changes

good again for review https://github.com/cloudposse/atmos/pull/767

Hi Team, this PR is good to review now. Thank you
https://github.com/cloudposse/atmos/pull/761

@Haitham looks like this is almost ready. I think there’s one outstanding comment. https://github.com/cloudposse/atmos/pull/727/files

@Andriy Knysh (Cloud Posse) this is ready for final review: https://github.com/cloudposse/atmos/pull/757
cc @Michael

@Andriy Knysh (Cloud Posse) this is ready for final review (works for me)
https://github.com/cloudposse/atmos/pull/761

@Andriy Knysh (Cloud Posse) I think this is also ready for final review
cc @Vinny https://github.com/cloudposse/atmos/pull/737

@Andriy Knysh (Cloud Posse) I think this is ready for your review. @Haitham and me have tagged you in some comments.

https://github.com/cloudposse/atmos/pull/768

@Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/762#discussion_r1838875067

@Andriy Knysh (Cloud Posse) all is resolved here ready to merge
https://github.com/cloudposse/atmos/pull/737

good to review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/764

@Vinny https://github.com/cloudposse/atmos/pull/782#issuecomment-2476217333

@Andriy Knysh (Cloud Posse) is this the correct explanation? https://github.com/cloudposse/atmos/pull/769/commits/d2cc5ec78569db7024f0813a351b72a0f6050768

@Andriy Knysh (Cloud Posse) can you take a look at this https://github.com/cloudposse/atmos/issues/781#issuecomment-2478506957

@Vinny make sure when referencing issues to say "Closes #123" so that when the PR is merged, the issue will get closed automatically

Took a stab at prettying up the JSON indentation for generated files such as backend.tf.json (https://github.com/cloudposse/atmos/pull/783). Feel free to rework or disregard if this doesn't meet the need! I tested it across five or so of our stacks

@Andriy Knysh (Cloud Posse) this should fix the regression raised by @Michael by disabling the custom prompt by default and enhancing it so it can be customized via the atmos config.


https://github.com/cloudposse/atmos/pull/786

Just one question here: https://linear.app/cloudposse/issue/DEV-2713/automatic-templated-file-search-for-atmos-imports. It looks like the .tmpl files take precedence over the .yaml, .yml extensions is that right?

I've started documenting some dev conventions for atmos that I feel we struggle with. Note that these are the intents, but they are not necessarily how Atmos works today. We need everyone's help to conform to these conventions and update atmos as we encounter inconsistencies with these conventions.

https://github.com/cloudposse/atmos/pull/793

this is good to final review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/764

this is good to start review @Andriy Knysh (Cloud Posse)
https://github.com/cloudposse/atmos/pull/795

@Michael I am extremely excited for the list commands you implemented! ❤️
https://github.com/cloudposse/atmos/pull/797

Hello @Andriy Knysh (Cloud Posse) this is good to start review https://github.com/cloudposse/atmos/pull/798

@Andriy Knysh (Cloud Posse) this looks ready for review https://github.com/cloudposse/atmos/pull/782

One thing I forgot to ask: it seems that running help without the flag doesn’t display the interactive menu from Cobra. Is that intentional?

this is ready for review again @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/798

Just made some more documentation updates and additional error handling for the list commands! Feel free to review whenever you get the chance!
https://github.com/cloudposse/atmos/pull/797

https://github.com/cloudposse/atmos/pull/795 good for review again @Andriy Knysh (Cloud Posse), once we get into a good state with the changes I will publish final evidences before we get ready to merge

good for final review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/798

very good for final review https://github.com/cloudposse/atmos/pull/782 @Andriy Knysh (Cloud Posse)

@Andriy Knysh (Cloud Posse) hi, have pushed a PR, would you please take a look/possibly approve in case no changes are required? https://github.com/cloudposse/atmos/pull/809

thank you all for the PRs. I'll review all of them after I finish some other tasks (prob tonight or tomorrow morning)