#atmos-dev - October 2024

@Erik Osterman (Cloud Posse) has joined the channel

@U079VSXEQ5D has joined the channel

@Andriy Knysh (Cloud Posse) has joined the channel

@Igor Rodionov has joined the channel

@Jeremy G has joined the channel

set the channel topic: Discuss atmos core development (golang)

@Haitham has joined the channel

@Vinny has joined the channel

@Haitham lets move discussion here. @Andriy Knysh (Cloud Posse) can you help answer some questions to unblock him?

@Andriy Knysh (Cloud Posse) it is related to the part func LogError log_utils.go line 85

func LogError(cliConfig schema.CliConfiguration, err error)

the cliConfig has value cliConfig.Logs.Level
on many cases on call func they pass empty value
that force me to add global value
branch https://github.com/cloudposse/atmos/tree/DEV-340

@kazuki has joined the channel

@david has joined the channel

@Michael has joined the channel

@Charles has joined the channel

@M Hunter has joined the channel

hello! hope you guys are good, which person should I ask review in my PR's?

https://linear.app/cloudposse/issue/DEV-2333/atmos-workflows-segfaults
cannot reproduce this issue now, I guess its fixed?

@johncblandii has joined the channel

Hey team, I was looking into some Atmos issues and wanted to take a crack at supporting component.yaml|.yml files for vendoring, and I opened a PR here (https://github.com/cloudposse/atmos/pull/725), but I was curious if the team had any preferences or recommendations on how to accomplish it. Feel free to disregard, close, or add another approach and I can take a crack at it

@suzuki-shunsuke has joined the channel

@Cheng JunKai has joined the channel

@Andriy Knysh (Cloud Posse) I guess we need to define the struct of this vendor yaml before hand? if yes can you give a sample please?
https://linear.app/cloudposse/issue/DEV-2378/vendor-path-setting-in-atmosyaml-to-specify-vendoryaml-path

what is the best examples folder to test the env variables outputs from terraform?

@Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/731#issuecomment-2425354614

Hey, to use a dynamic version in the config.go file, we would need to restructure the version package, as it is currently creating a circular dependency, appreciate any suggestions

https://linear.app/cloudposse/issue/DEV-1880/filter-out-empty-results-from-describe-stacks
Do we have any naming requirements for the filter option (e.g., grep or filter), and should it default to filtering out empty results unless explicitly included by a flag?
If no filters are applied, what should the default behavior be? Also, can you provide a example folder to test, otherwise I will create one

@Charles has joined the channel

my life would change if I had found this earlier 🙂

@Erik Osterman (Cloud Posse) one question for https://linear.app/cloudposse/issue/DEV-2337/set-custom-user-agent-for-terraform-aws-provider are we going to let users also add an user agent and overwrite the atmos default value or not?

Hey team,
The PR #729 for Atmos is ready for review. Please keep the following points in mind:
• The version package has been migrated. This is a bit out of scope for the task, but it was necessary to get the it done. Please review it carefully. I’ve tested everything and ensured it works correctly. I’ve also confirmed there’s no impact on terraform-provider-utils, but I’m not certain if there are other repos that could be affected.
• We might want to inform users about the version package migration.
• I’ve omitted TF_APPEND_USER_AGENT from atmos.yaml since it’s already set by default in the code. However, we might want to add it to all yaml files for better user transparency and guidance on how to use it.
• Rabbit’s comments have been reviewed and replied to, and I’ve closed the remaining ones.
• New test images have been provided in the PR.
Please mark addressed comments as resolved, Cheers.

just to clarify here that empty stack means no components right like this example bellow https://linear.app/cloudposse/issue/DEV-1880/filter-out-empty-results-from-describe-stacks

vars:
  stage: dev

import:
  - catalog/myapp

#components:
#  terraform:
#    myapp:
#      vars:
#        location: Stockholm
#        lang: se

if you are working on a PR and have addressed PR comments, please ping me here for re-review

cc @Vinny @Haitham

@Andriy Knysh (Cloud Posse) we don't use the _yaml_path convention elsewhere, I don't think we should introduce it here.

Also, since it's nested underneath vendor, no need to prefix it. It's also inconsistent with other conventions, see helmfile and terraform, which use base_path
cc @Vinny

@Andriy Knysh (Cloud Posse) I think this is ready for merge. You can ignore the failing demo-helmfile test
https://github.com/cloudposse/atmos/pull/740

cc @Haitham

https://github.com/cloudposse/atmos/issues/750

@Vinny this probably relates to https://github.com/cloudposse/atmos/pull/729

@RB has joined the channel

https://github.com/cloudposse/test-helpers/pull/31 @Andriy Knysh (Cloud Posse) for review please

closing https://github.com/cloudposse/atmos/issues/750

@Pulak Kanti Bhowmick has joined the channel

@Vitalii has joined the channel

Hello Team,
I need one clarification on this Default value for demo argument should not cause an error

Where there is multiple arguments are required, if user doesn't provide one, in that case, it is hard to identify the order of argument given by user. What should we do in this case?

My opinion: For flags, we have that option to keep flag optional with default value. It seems, arguments are always required and users have to pass those. But if user doesn't give any arguments, only then we can use the default arguments for any command. But If they pass some and skip some, there is no way to identify which arguments are missing and which are given.

Please share your thoughts! Thank you so much!

@Andriy Knysh (Cloud Posse) this is good to review please
https://github.com/cloudposse/atmos/pull/737