#terraform-aws-modules - August 2024

How come the terraform aws ec2 instance module ignores changes on ami changes ? What if you want to rotate a singleton and don’t mind the downtime ?

https://github.com/cloudposse/terraform-aws-ec2-instance/blob/cb7559596b69d0b4ca31942ca2eda59a1e5bb18e/main.tf#L171-L175

Came from PR https://github.com/cloudposse/terraform-aws-ec2-instance/pull/145 but wasn’t called out explicitly

What do you folks think about defaulting these inputs in the s3 bucket module ?

  # Recommended by aws to use BucketOwnerEnforced
  # ObjectWriter is used for backwards compatibility and documented here in PR
  # <https://github.com/cloudposse/terraform-aws-s3-bucket/pull/127>
  s3_object_ownership = "BucketOwnerEnforced"
  # most s3 buckets do not need to enable versioning
  # This was toggled to false due to a compliance PR 
  # <https://github.com/cloudposse/terraform-aws-s3-bucket/pull/70>
  versioning_enabled  = false

Hi there, what's cloudposse point of view on policy passed as variable? Is it preferred to pass the whole policy as json, or use a datasource and partially pass part of the policy or create an object representing the policy and set the variable for the policy as object.. what's the preferred way? I'm not talking about assumerole, which is quite standard and easy to set without passing the whole object, I'm talking for example about a resource policy. I cannot find an example of your repo, it seems all of the above ways have been used, I just wanted to check if there's a preference.