21 messages
Pull Request Reviews for Cloud Posse Projects
Ben Smith (Benbentwo)20 days ago
github.com/cloudposse/terraform-aws-s3-log-storage/pull/141 looks a little stuck -
/terratest looks to have run for some checks but not all - @Andriy Knysh (Cloud Posse) if you get a moment could you take a lookMichal Tomaszek19 days ago
Could someone review this version pinning PR?
github.com/cloudposse/github-action-matrix-extended/pull/25
github.com/cloudposse/github-action-matrix-extended/pull/25
Ivan Pinatti18 days ago(edited)
Could I please get a review on these 3 PRs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/50
◦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
• github.com/cloudposse-terraform-components/aws-redshift/pull/49
◦ Removes an output that no longer exists on the wrapped module
• github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
◦ Makes the parameter group family configurable so RA3/RG clusters can be managede
• github.com/cloudposse-terraform-components/aws-redshift/pull/50
◦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
• github.com/cloudposse-terraform-components/aws-redshift/pull/49
◦ Removes an output that no longer exists on the wrapped module
• github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
◦ Makes the parameter group family configurable so RA3/RG clusters can be managede
Ivan Pinatti18 days ago
One more PR, this is a bug in the ssm path, easy review.
• github.com/cloudposse-terraform-components/aws-redshift/pull/51
• github.com/cloudposse-terraform-components/aws-redshift/pull/51
Ivan Pinatti17 days ago
Another PR, unrelated with the previous ones. Could I please also get a review?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
◦ Changes the archive bucket lifecycle default from
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
◦ Changes the archive bucket lifecycle default from
GLACIER to GLACIER_IR. Datadog can't read GLACIER for rehydration or Archive Search, so on the default config the archive silently becomes unreadable a year after the first object lands.Ivan Pinatti14 days ago(edited)
Could I please get a review on these 4 PRs?
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period
Two small things that would help:
• The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period
Two small things that would help:
• The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
Ben Smith (Benbentwo)14 days ago
Small pr for EKS Cluster github.com/cloudposse-terraform-components/aws-eks-cluster/pull/95
Ben Smith (Benbentwo)14 days ago
One tiny PR for EKS Cluster module github.com/cloudposse/terraform-aws-eks-cluster/pull/266
Ivan Pinatti13 days ago
Please could I get a review on this PR?
• github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard
• github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard
domain_namePePe Amengual12 days ago
If I could gets some eyes on https://github.com/cloudposse-terraform-components/aws-config/pull/69
Ivan Pinatti12 days ago(edited)
Could I please get an approval review on these two Renovate PRs? Both are green and just blocked on
• github.com/cloudposse-terraform-components/aws-redshift/pull/55
• github.com/cloudposse-terraform-components/aws-redshift/pull/46
REVIEW_REQUIRED.• github.com/cloudposse-terraform-components/aws-redshift/pull/55
• github.com/cloudposse-terraform-components/aws-redshift/pull/46
Ivan Pinatti12 days ago
Could I also get a review on this PR please?
• github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
• github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
Ivan Pinatti11 days ago
Happy Friday! The last PR for this week, could I please get a review?
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including
cluster_parameter_group_family which RA3/RG clusters needIvan Pinatti7 days ago
Please could I get a review on this PR?
• github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
• github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
PePe Amengual6 days ago(edited)
any reason why the IPAM component used https://github.com/aws-ia/terraform-aws-ipam instead of a cloudposse managed module? last release of the AWS maintained module is a year old, are you guys open on creating a cloudposse owned module? ( I have cycles and interest)
PePe Amengual6 days ago
this is ready for review https://github.com/cloudposse/terraform-aws-ipam/pull/3
Michael5 days ago
If anyone has a chance to review, this adds some SSM functions to the test-helpers package. When we build an AMI with Packer, we use Terraform, Terratest, and SSM to run host checks to ensure it's configured as we intend. Contributing these back to the community for other's use could be beneficial for reusability
github.com/cloudposse/test-helpers/pull/99
github.com/cloudposse/test-helpers/pull/99
Ivan Pinatti5 days ago
Could I get a review please?
• github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks
• github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks
aws-datadog-monitor, where terraform init and terraform validate both fail on main todayIvan Pinatti4 days ago
Hey, could I please get a review on this one?
• github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
• github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
Ivan Pinattiabout 12 hours ago(edited)
Hello, could I get a review on this PR please?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.