10 messages
Pull Request Reviews for Cloud Posse Projects
Michael20 days ago
Small PR after running tflint on the s3 bucket module: https://github.com/cloudposse-terraform-components/aws-s3-bucket/pull/82
Miguel Zablah18 days ago
PR to update module to AWS v6 and also update some modules:
https://github.com/cloudposse/terraform-aws-config/pull/141
https://github.com/cloudposse/terraform-aws-config/pull/141
Quentin BERTRAND17 days ago
Hi Clouders!
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
Michael13 days ago
Could I get a review of this change that fixes some tflint findings, typos, and adds support for
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
force_update_version and control_plane_scaling_config for the EKS module?https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Marat Bakeev12 days ago
Hey 👋 Opened a small bug-fix PR for the atmos ansible playbook command: https://github.com/cloudposse/atmos/pull/2594
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native
ansible-playbook flags through.Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".
Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.
Would appreciate a review when someone has a cycle 🙏
Michael10 days ago
Not sure if the team would have any interest in this but it adds support for govcloud AWS accounts: https://github.com/cloudposse-terraform-components/aws-account/pull/56
Marat Bakeev7 days ago
A small PR to add support for using local instance store disks in karpenter node pools - https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/73
Marat Bakeev3 days ago
Hi guys, somewhat large bump to cognito component - https://github.com/cloudposse-terraform-components/aws-cognito/pull/63
Let me know if this is not acceptable.
Let me know if this is not acceptable.
Brian1 day ago
https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this
atmos secret list -s <stack> against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.