11 messages
Pull Request Reviews for Cloud Posse Projects
M
Michael3 months ago
Can I get a PR review on this Elasticsearch component improvement? This introduces new configuration options and refactors how key variables are set and passed to the Elasticsearch module. The main focus is on improving flexibility for domain and subdomain naming, advanced security options, and storage configuration, while making these options configurable via input variables
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
M
Michael3 months ago
Would I be able to get a review on changing the Helm provider version constraint from
for the EKS Datadog Agent component?
https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/69
>= 2.7 to ~> 2.7for the EKS Datadog Agent component?
https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/69
T
Tomasz GΕuch3 months ago
Hi folks,
could I ask you to review https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/96? This change isn't mine, but I've been testing it recently and it works great. The current version of this module has one simple but serious drawback that makes it difficult to use in a real environment.
could I ask you to review https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/96? This change isn't mine, but I've been testing it recently and it works great. The current version of this module has one simple but serious drawback that makes it difficult to use in a real environment.
Y
Yevdokiia Mazhak3 months ago
hello!
anyone that can have a look at https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/162?
anyone that can have a look at https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/162?
E
D
david2 months ago
May I get a review on this SQS -> Lambda trigger please https://github.com/cloudposse-terraform-components/aws-lambda/pull/44
T
Tyler Rankin2 months ago
Irregular contributor here π
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
/test that need to be made. Thanks!https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
M
Michael2 months ago
May I get a review on this Geodesic PR? https://github.com/cloudposse/geodesic/pull/980
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
array=($(command)) with the more robust mapfile -t array < <(command) syntax- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
M
Marat Bakeev2 months ago
Hi everyone, can you please review this PR - https://github.com/cloudposse-terraform-components/aws-eks-alb-controller-ingress-class/pull/50
B
Bruce2 months ago
client vpn component broke after latest update:
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
N
Nitinabout 2 months ago
Hello everyone, can you please review this PR
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278