10 messages
Pull Request Reviews for Cloud Posse Projects
Sushmitha Kumarabout 1 year ago
Hi #pr-reviews, Please review these PRs
aws-cognito https://github.com/cloudposse-terraform-components/aws-cognito/pull/12 , aws-ecr https://github.com/cloudposse-terraform-components/aws-ecr/pull/14, aws-opsgenie-team https://github.com/cloudposse-terraform-components/aws-opsgenie-team/pull/15, aws-documentdb https://github.com/cloudposse-terraform-components/aws-documentdb/pull/15 for splat expressions.Sushmitha Kumarabout 1 year ago
Hi #pr-reviews, please review my PR for
aws-cognito https://github.com/cloudposse-terraform-components/aws-cognito/pull/12 on splat expressionsSushmitha Kumarabout 1 year ago
Hi #pr-reviews, Just a reminder, PR :https://github.com/cloudposse-terraform-components/aws-cognito/pull/12 has been pending review for a week. Could someone check it out when possible? Thanks!
Michaelabout 1 year ago
No rush on this one, but whenever the tests are written for the Karpenter Controller component, this addition adds a toggle for sending Karpenter metrics to the Datadog Integration. We have been using it for a few months now, and it has added a lot of value and given us visibility into our clusters
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-controller/pull/15
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-controller/pull/15
Yangci Ouabout 1 year ago
No rush on this but putting it out there, straightforward PR on the Amplify module, https://github.com/cloudposse/terraform-aws-amplify-app/pull/46 to allow for custom header responses on Amplify.
Ricky Fontaineabout 1 year ago
Hi everyone! I've raised a PR for the
This fixes a bug where a local variable references non-existent attributes from an input variable. Running
Let me know if you need more info!
aws-eks-cluster component: https://github.com/cloudposse-terraform-components/aws-eks-cluster/pull/18This fixes a bug where a local variable references non-existent attributes from an input variable. Running
tf plan after vendoring the latest release produced the error:│ Error: Unsupported attribute
│
│ on main.tf line 48, in locals:
│ 48: for role in var.map_additional_iam_users : role.rolearn => {
│
│ This object does not have an attribute named "rolearn".Let me know if you need more info!
Michaelabout 1 year ago
This PR adjusts the default value for the
https://github.com/cloudposse/terraform-aws-amplify-app/pull/47
custom_headers variable in the Amplify app module to fix validation failureshttps://github.com/cloudposse/terraform-aws-amplify-app/pull/47
Asghiabout 1 year ago
Hey folks, I’ve opened a PR to add
PR link: https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/252
Closes/Fixses following issue : https://github.com/cloudposse/terraform-aws-elasticache-redis/issues/251
Thanks in advance!
snapshot_arns_to_restore support for Serverless ElastiCache in the terraform-aws-elasticache-redis module. Could someone please review when you have a moment?PR link: https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/252
Closes/Fixses following issue : https://github.com/cloudposse/terraform-aws-elasticache-redis/issues/251
Thanks in advance!