#pr-reviews - May 2021 | Slack Archive

Alex Tayloralmost 5 years ago

https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/115 - Review please 🙂

Alex Tayloralmost 5 years ago(edited)

https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/116
We've created a draft based on the feedback from above ^^

This has added a third ecs service that right now only ignores the changes to desired_count (So we don't have one for both desired count + task definition because right now we don't have the use-case for it, I'd rather that be added later if its needed) - want to know any thoughts on this before creating a PR and changing our code / moving remote state to avoid any unnecessary changes

kevcubealmost 5 years ago

Hi 👋

Please give a super quick review to This PR

nnsensealmost 5 years ago

Hi there, here we go 🙂
https://github.com/cloudposse/terraform-aws-rds/pull/115

Malmost 5 years ago

super quick one to review please https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/69

Malmost 5 years ago

and another quick one please https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/169

Frankalmost 5 years ago

https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/148 Can someone take a look at this one?