73 messages
Discuss atmos core development (golang). If you want to help out, reach out to @Erik Osterman (Cloud Posse)
Andriy Knysh (Cloud Posse)12 days ago
@Erik Osterman (Cloud Posse) please review github.com/cloudposse/atmos/pull/3034
erik12 days ago
@Andriy Knysh (Cloud Posse) I have 5 PRs incoming to tackle the recent flakiness. It's partly due to the harden-runners, but also other things like windows defender scanning every file we unpack from the cache. Turning that off for cache unpacking reduces time from 5-10m to 1m.
Here's the first PR in the series. github.com/cloudposse/atmos/pull/3037
Here's the first PR in the series. github.com/cloudposse/atmos/pull/3037
erik12 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3039/changes (small one)
erik12 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3040 since we run on spot instances, and run quite a lot of jobs, there's some % that get interrupted simply by infrastructure issues. This is introduces a job that runs when workflows complete and inspects why they failed; if it is related to losing connections to the github control plane, instances getting shutdown, etc, it will retrigger them automatically.
erik11 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3022 finally ready after 20+ rounds of fixing races and shuffling tests. This increases overall stability.
erik11 days ago
@Andriy Knysh (Cloud Posse) since our release drafter keeps failing due to exceeding the release notes size, this introduces OpenAI summarization using a new mage target.
https://github.com/cloudposse/atmos/pull/3045
https://github.com/cloudposse/atmos/pull/3045
erik11 days ago
@Andriy Knysh (Cloud Posse) this introduces runtime process metrics, terraform plan/apply stats, and output in atmos so we can track and sent to atmos pro, when enabled. I collaborated on this PR so I cannot approve.
github.com/cloudposse/atmos/pull/2926
github.com/cloudposse/atmos/pull/2926
erik11 days ago
@Andriy Knysh (Cloud Posse) this addresses one of the windows flakes we've been seeing
github.com/cloudposse/atmos/pull/3057
github.com/cloudposse/atmos/pull/3057
erik11 days ago
@Andriy Knysh (Cloud Posse) this converts a shell step to a mage target with tests. We have the aggregate jobs that wait for the success of the shards so we can require them to pass. There was a flake in waiting for the conclusion, which isn't always immediately available after the shards complete.
https://github.com/cloudposse/atmos/pull/3052
https://github.com/cloudposse/atmos/pull/3052
erik10 days ago
@Andriy Knysh (Cloud Posse) this has a 3-4x speed up in GH cache operations on windows by using the
d:\ drive instead of c:\ ; e.g. cache restores taking 1.5 min instead of 6 minutes.erik10 days ago
@Andriy Knysh (Cloud Posse) cut a release once these merge today, if you happen to be around. github.com/cloudposse/atmos/milestone/3
cc @Igor Rodionov
cc @Igor Rodionov
erik8 days ago
@Andriy Knysh (Cloud Posse) this fixes a bug where concurrent website deploys would result in a corrupt deployment. This is something that started happening due to more rapid merges due to merge queues.
github.com/cloudposse/atmos/pull/3072
github.com/cloudposse/atmos/pull/3072
erik7 days ago
Jorrit Elfferich7 days ago
Hey folks, these 2 are ready 🙌 :
• github.com/cloudposse/atmos/pull/3048
• github.com/cloudposse/atmos/pull/3047
• github.com/cloudposse/atmos/pull/3048
• github.com/cloudposse/atmos/pull/3047
erik7 days ago
erik7 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3077 warm our build caches
erik7 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3069 this extends our version tracker to support arbitrary YAML files in addition to the JSON files already supported. Also it allows the version to be preprocessed prior to writing.
erik7 days ago
@Andriy Knysh (Cloud Posse) since we've already solved all the race conditions in our tests and ensured they pass with shuffled order, it was pretty easy to now massively parallelize all our tests. Code rabbit cannot approve though since it modifies more than 150 files; however all the changes are more or less the same: adds
github.com/cloudposse/atmos/pull/3078
t.Parallel everywhere. The only exceptions are where we update the mage files to increase parallelism to use it.github.com/cloudposse/atmos/pull/3078
erik6 days ago
@Andriy Knysh (Cloud Posse) this adds a homebrew skill for making changes to our formula
github.com/cloudposse/atmos/pull/3081
github.com/cloudposse/atmos/pull/3081
erik6 days ago
@Andriy Knysh (Cloud Posse) we should merge this before anything else to prevent schema's from getting deleted github.com/cloudposse/atmos/pull/3092
erik6 days ago
@Andriy Knysh (Cloud Posse) this fixes a bug in
atmos terraform test JUNIT handling github.com/cloudposse/atmos/pull/3082erik6 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3074 prd update and flake fix
erik6 days ago
@Andriy Knysh (Cloud Posse) this adds the ability to download the casts on
/examples as MP3/GIF/WEBM/etc...github.com/cloudposse/atmos/pull/2739erik6 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3099this adds links to related documentation in our changelog
erik5 days ago
@Andriy Knysh (Cloud Posse) this improves the cast download DX when rendering a cast for the first time. github.com/cloudposse/atmos/pull/3115
erik5 days ago
@Zack I wonder if this solves some of your problems without
github.com/cloudposse/atmos/pull/3095
requiredgithub.com/cloudposse/atmos/pull/3095
erik4 days ago
@Andriy Knysh (Cloud Posse) support flags to override values at runtime for helm like we do for terraform (and like
github.com/cloudposse/atmos/pull/3094
helm itself supports).github.com/cloudposse/atmos/pull/3094
erik4 days ago
@Andriy Knysh (Cloud Posse) this coverts our race tests to shards since they were the long pole now that we got tests under 20 minutes.
github.com/cloudposse/atmos/pull/3123
github.com/cloudposse/atmos/pull/3123
erik4 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3125 after merging, we'll get timing stats on the duration of runs posted as a sticky comment so we can keep an eye on time spent running tests.
erik4 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3121 fixes a reported issue with the newly introduced
--ui when there are only changes in outputs.erik4 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3126 adds the ability to download casts from our changelog, and adds cast previews to the changelog page.
Andriy Knysh (Cloud Posse)3 days ago
@Erik Osterman (Cloud Posse) github.com/cloudposse/atmos/pull/3134 - fixes an issue with Atmos Helm
create_namespace settingerik2 days ago
@Andriy Knysh (Cloud Posse) add support for atmos test ui, by introducing a new step type called "test"
github.com/cloudposse/atmos/pull/3124
github.com/cloudposse/atmos/pull/3124
erik2 days ago
@Andriy Knysh (Cloud Posse) one of the frequent requests is for atmos not to re-init when unnecessary. This adds that ability (configurable).
github.com/cloudposse/atmos/pull/3127
github.com/cloudposse/atmos/pull/3127
Andriy Knysh (Cloud Posse)2 days ago
@Erik Osterman (Cloud Posse) please review github.com/cloudposse/atmos/pull/3162
shirkevich1 day ago
wow, I missed that you merged my helm prs, thank you guys! sorry that it took so long, was distracted with other tasks 🎉
Jorrit Elfferich1 day ago
Heyy folks. I have another feature ready for feedback 👉️ github.com/cloudposse/atmos/pull/3119
Keen on your thoughts!
Keen on your thoughts!
erik1 day ago
@Andriy Knysh (Cloud Posse) here's a PR stack that refactors all of our tests to use a GitHub facade. Plus, adds support for GHES.
This is to reduce flakes, and speed up tests.
It works by creating a
Review in order. Approve in order. Then merge as a stack.
1. github.com/cloudposse/atmos/pull/3105
2. github.com/cloudposse/atmos/pull/3107
3. github.com/cloudposse/atmos/pull/3109
4. github.com/cloudposse/atmos/pull/3122
This is to reduce flakes, and speed up tests.
It works by creating a
gitmirror and emulating the GitHub API in front of it for the calls we need. In order to use it, we needed to support custom GitHub endpoints, hence we went ahead and added GHES support and use that to point it at the local mock http started by the test runner.Review in order. Approve in order. Then merge as a stack.
1. github.com/cloudposse/atmos/pull/3105
2. github.com/cloudposse/atmos/pull/3107
3. github.com/cloudposse/atmos/pull/3109
4. github.com/cloudposse/atmos/pull/3122
erikabout 6 hours ago
@Andriy Knysh (Cloud Posse) harden the helm plugin installation github.com/cloudposse/atmos/pull/3167
erikabout 5 hours ago
@Andriy Knysh (Cloud Posse) this introduces concurrent vendoring the way we do with toolchain installation. Many users have extensive vendor configs and this should provide a nice speedup. cc @PePe Amengual
github.com/cloudposse/atmos/pull/3169
github.com/cloudposse/atmos/pull/3169
erikabout 5 hours ago