#atmos-dev - January 2025

@Andriy Knysh (Cloud Posse) this is ready for review https://github.com/cloudposse/atmos/pull/853

I am not able to reproduce this anymore https://linear.app/cloudposse/issue/DEV-2845/atmos-panics-instead-of-showing-error-for-incorrect-command

@Andriy Knysh (Cloud Posse) this LGTM https://github.com/cloudposse/atmos/pull/905

@Andriy Knysh (Cloud Posse) looks like good now
https://github.com/cloudposse/atmos/pull/853

@Andriy Knysh (Cloud Posse) I think this is also ready https://github.com/cloudposse/atmos/pull/906

This is good to start review @Andriy Knysh (Cloud Posse)
https://github.com/cloudposse/atmos/pull/907

This is good to start review @Andriy Knysh (Cloud Posse)
https://github.com/cloudposse/atmos/pull/909

@Andriy Knysh (Cloud Posse) note this failed on tests during release due to github API rate limits.

https://github.com/cloudposse/atmos/actions/runs/12637455883

I think this might be fixed when we support bearer tokens as part of https://github.com/cloudposse/atmos/pull/912

cc @Andrey Kalmykov

@Andriy Knysh (Cloud Posse) hotfix for Prod
https://github.com/cloudposse/atmos/pull/916

@Andriy Knysh (Cloud Posse) hi, having a discussion with Erik on go-getter v1 vs v2. Would appreciate if you share your view, see below.

@Andriy Knysh (Cloud Posse) PR TTY back ready for review https://github.com/cloudposse/atmos/pull/919

@Andriy Knysh (Cloud Posse) this LGTM https://github.com/cloudposse/atmos/pull/845
cc @Shubham Tholiya

Heads up, k3s-demo is failing because bitnami chart repo is having problems:
https://github.com/bitnami/charts/issues/31257

this is good to review please @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/913

Major GitHub outages for PRs, Git operations, actions, and webhooks for awareness

@Andriy Knysh (Cloud Posse) this is almost ready. Just a small comment from me regarding timestamps.

https://github.com/cloudposse/atmos/pull/919

This is ready for review https://github.com/cloudposse/atmos/pull/891

Definitely should be tested on Windows. Tests are passing now.

One minor command remains. @Dan Miller (tembo) is going to update some of the example/demos-* to use relative paths.

@Dan Miller (tembo) something I missed in your PR. I don't like the name of these test-cases: complete because it's neither complete, nor based on a convention. If it were based on a scenario or demo, I think it would make more sense.

Good morning 🌞

I see terraform is failing on latest version CI @Andriy Knysh (Cloud Posse) @Erik Osterman (Cloud Posse)

@Matt Calhoun - no good deed goes unpunished

The eol PR broke releases


https://github.com/cloudposse/atmos/actions/runs/12714711809/job/35446199346

@Andriy Knysh (Cloud Posse) ready for final review: https://github.com/cloudposse/atmos/pull/919

@Andriy Knysh (Cloud Posse) this is also ready for final review: https://github.com/cloudposse/atmos/pull/912

Did the Atmos 1.146.0 Cloudsmith package release complete? Looks like it isn't available

@Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/923 this is good for review

@Andriy Knysh (Cloud Posse) this is ready for review https://github.com/cloudposse/atmos/pull/896

@Andriy Knysh (Cloud Posse) simple one liner from @Dan Hansen
https://github.com/cloudposse/atmos/pull/936

https://github.com/cloudposse/atmos/pull/940
Ready to review again 🙂

TestCLICommands/atmos_terraform_deploy_unlocked_component (24.05s)
This test is flaky is someone already working on it?
Or should i create a ticket for this. We can then later decide who picks this up

@Andriy Knysh (Cloud Posse) I think this is ready for final review: https://github.com/cloudposse/atmos/pull/919

@Andriy Knysh (Cloud Posse) this is ready for final review: https://github.com/cloudposse/atmos/pull/930

@Andriy Knysh (Cloud Posse) do you have thoughts on this PR: https://github.com/cloudposse/atmos/pull/923

@Andriy Knysh (Cloud Posse) good morning, this is ready for review https://github.com/cloudposse/atmos/pull/946

@Andriy Knysh (Cloud Posse) any concerns other than the ones I raised? If @shirkevich fixes those are we good to merge?

https://github.com/cloudposse/atmos/pull/942

@Andriy Knysh (Cloud Posse) @Shubham Tholiya @Vinny golden snapshots are ready for final review. Tests are passing.

This adds:
• TTY support
• Skip lists, diffs, !not negation
• Mitigates GitHub API rate limits by passing GITHUB_TOKEN everywhere
• Introduces go.sum linting, and better merge strategy to avoid constant merge conflicts.
• And more...
https://github.com/cloudposse/atmos/pull/939

https://github.com/cloudposse/atmos/pull/914
Let us push this guys.
It is growing a lot...And we already spent a lot of time on rebasing this thing

having this for CI on mac

Greetings. I am getting a timeout error when I run make testacc on a fresh pull. Is it due to my slow internet or something else?
I am on Mac OS X

=== RUN   TestCLICommands/atmos_vendor_pull_(no_tty)
panic: test timed out after 2m0s
	running tests:
		TestCLICommands (2m0s)
		TestCLICommands/atmos_vendor_pull_(no_tty) (31s)

Hi this is ready for review @Andriy Knysh (Cloud Posse)
https://github.com/cloudposse/atmos/pull/941

Hi @Andriy Knysh (Cloud Posse) this is ready for review
https://github.com/cloudposse/atmos/pull/957

@Andriy Knysh (Cloud Posse), @Haitham rebased his PRs.

I resolved it

hello

https://github.com/cloudposse/atmos/pull/899
has issues after rebase with main branch on test cases
I am working on fix it

finally its work now

can you review this https://github.com/cloudposse/atmos/pull/899/files#r1922949960

I added est for relative path import its work now

This is ready for final review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/941

@Andriy Knysh (Cloud Posse) this is ready for final review
https://github.com/cloudposse/atmos/pull/957

@Matt Calhoun Azure Store functionality contributed by @PePe Amengual https://github.com/cloudposse/atmos/pull/963

🧵 @Vinny @Samuel Than @Andrey Kalmykov re: command examples.

@Shubham Tholiya is this a regressoin?
https://github.com/cloudposse/atmos/pull/870/files/d5cca3252c2ca00c4bdcebf150d97ab3617ecdea#r1924464197

cc @Haitham

@Andriy Knysh (Cloud Posse) ready for final review: https://github.com/cloudposse/atmos/pull/899

cc @Haitham

getting this annoying issue from time to time running tests in local, anyone else?

I suspect there is a test that doesn’t maybe have a workdir

And depending on where you run or how you invoke go test the outcome will be different

@Andriy Knysh (Cloud Posse) this looks ready for final review https://github.com/cloudposse/atmos/pull/941/files

please review final https://github.com/cloudposse/atmos/pull/941 @Erik Osterman (Cloud Posse) @Andriy Knysh (Cloud Posse)

please review final changes https://github.com/cloudposse/atmos/pull/957 @Erik Osterman (Cloud Posse) @Andriy Knysh (Cloud Posse)

Hey atmos cli dev's
Just a note while you create new commands.

Whenever you want to specify an example. Please use markdown files.
The new update to the command line platform would actually use that markdown both in Incorrect Usage and Help scenarios.
Refer to my pr here; https://github.com/cloudposse/atmos/pull/959

is this expected or not?

@Andriy Knysh (Cloud Posse) this is ready for final review

https://github.com/cloudposse/atmos/pull/870

Hope my comment was not missed 🙂
https://github.com/cloudposse/atmos/pull/957#issuecomment-2614340251
cc: @Erik Osterman (Cloud Posse) @Vinny

@Andriy Knysh (Cloud Posse) this is ready for final review:

https://github.com/cloudposse/atmos/pull/979#pullrequestreview-2583760928

@Andriy Knysh (Cloud Posse) @Matt Calhoun any opposition to this? I think it sounds like a good idea.

https://github.com/cloudposse/atmos/pull/985

@suzuki-shunsuke I will fix the build harness issue in a few hours

Just a heads-up, everyone—expect some more merge conflicts as we push forward with significant improvements. I know this is frustrating and disruptive, and I truly appreciate your patience. It’s part of the necessary growing pains as we level up. Thanks for bearing with us! 🙏

• #980 (overhauls our logging, so we no longer need to pass the atmos configuration around, but touches almost every file; fortunately, the changes are pretty easy to spot in a conflict) @Matt Calhoun
• #957 (fixes more rate limit issues causing tests to fail, adds timeouts for test cases, and sandboxes tests in a virtual home directory; it also add validation to log levels which is redundant with #980) @Vinny @Erik Osterman (Cloud Posse)
• #959 (fixes more of the cobra validation, adds markdown support to output, and also touches almost everything. Hopefully this completes the cobra refactor and validation work.) @Shubham Tholiya
Unfortunately, fixes in 957 are needed for tests in 980 to pass (namely about running each tests/test-cases in a sandbox for stable reproduction of tests), so I disabled the snapshot test that was failing.

My proposal is we merge them in the order above, after resolving the conflicts.

Other PRs likely affected too.

having error stuck on this, using make testacc

        Workspace "prod-station" doesn't exist.
        
        You can create this workspace with the "new" subcommand 
        or include the "-or-create" flag with the "select" subcommand.