pr-reviews
2992,976
Pull Request Reviews for Cloud Posse Projects
R
RB2 days ago
Please also review upgrading node runtime to node24 in github-action-pre-commit repo
https://github.com/cloudposse/github-action-pre-commit/pull/32/changes
https://github.com/cloudposse/github-action-pre-commit/pull/32/changes
R
RB2 days ago(edited)
Please review updating gha atmos affected stacks
β’ Fix test and dep upgrade https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/82/changes
β’ fix injection points https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/85/changes
β’ dep upgrades
β¦ aws-actions/configure v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/81/changes
β¦ setup-node v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/76/changes
β’ renovate best practices https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/67/changes
β’ Fix test and dep upgrade https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/82/changes
β’ fix injection points https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/85/changes
β’ dep upgrades
β¦ aws-actions/configure v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/81/changes
β¦ setup-node v6 https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/76/changes
β’ renovate best practices https://github.com/cloudposse/github-action-atmos-affected-stacks/pull/67/changes
R
RB7 days ago
S
Sean Nguyen7 days ago(edited)
The datadog
@johncblandii
https://github.com/cloudposse/terraform-datadog-platform/pull/125
monitors submodule is not compatible with the latest release of the DataDog Terraform provider.@johncblandii
https://github.com/cloudposse/terraform-datadog-platform/pull/125
R
R
RB13 days ago
Please review setting default instance type for all redis clusters
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/82
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/82
R
RB13 days ago
Please also review bumping the minimum aws provider for the elasticache redis component https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/81
R
RB13 days ago
Please review adding global engine_version default for all redis clusters https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/80
R
RB13 days ago
Please review allowing dns_subdomain to be overridden per cluster in redis clusters https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/79
A
aairey14 days ago
Hi can anyone please review:
β’ https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/81
β’ https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/81
R
R
R
RB16 days ago
Expose the rest of elasticache redis inputs
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/68
https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/68
I
Ivan Pinatti17 days ago
Another one, expose
β’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
num_shards and replicas_per_shard as component-level variablesβ’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
I
Ivan Pinatti17 days ago
One more PR, now to enable Slow and Engine logs options for Redis
β’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/
β’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/
I
Ivan Pinatti17 days ago
PR adding maintenance and snapshot window options for Elasticache Redis
β’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/64
β’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/64
I
Ivan Pinatti21 days ago
R
RB23 days ago
Another set of eyes here pleae https://github.com/cloudposse/terraform-aws-dynamodb/pull/141
J
Jakub WΔ
doΕowski27 days ago
I've just created two straightforward PRs that add
β’ https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
β’ https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
response_completion_timeout support to both CDN modules:β’ https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/159
β’ https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/369
Could someone take a look please?
R
RB28 days ago
Please review setting bucket key to true default https://github.com/cloudposse/terraform-aws-s3-bucket/pull/285
J
Jakub WΔ
doΕowski29 days ago
a small enhancement for the ECS web app module: https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/305. Would appreciate a review when you get a chance
D
david29 days ago
May I get a review please https://github.com/cloudposse-terraform-components/aws-api-gateway-rest-api/pull/46
M
Michaelabout 1 month ago
Sorry, quick patch fix for Datadog tags in the EKS agent: https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/75
M
MPabout 1 month ago
Hello π
Would I be able to get a review for this PR => https://github.com/cloudposse/atmos/pull/2058 ?
Reference: https://sweetops.slack.com/archives/C031919U8A0/p1770405166302539
Would I be able to get a review for this PR => https://github.com/cloudposse/atmos/pull/2058 ?
Reference: https://sweetops.slack.com/archives/C031919U8A0/p1770405166302539
M
Michaelabout 1 month ago
Small PR fix for Cognito component's failing validation: https://github.com/cloudposse-terraform-components/aws-cognito/pull/50
M
Michaelabout 1 month ago
Small PR for fixing a Datadog tag parsing misinterpretation: https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/74
R
RBabout 1 month ago
Please review changes to https://github.com/cloudposse-terraform-components/aws-account-settings/pull/52/files
M
Michaelabout 1 month ago
Would I be able to get a review on this bug fix? The change ensures that the validation conditions correctly handle
https://github.com/cloudposse-terraform-components/aws-cloudtrail-bucket/pull/56
null values by using a ternary operator instead of relying on logical OR, which can help avoid issues with type coercion.https://github.com/cloudposse-terraform-components/aws-cloudtrail-bucket/pull/56
I
Ivan Pinattiabout 2 months ago
Could I get one more review? ECS Component Naming fix
β’ https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/pull/79
β’ https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/pull/79
I
Ivan Pinattiabout 2 months ago
Hello everyone, happy Friday!
Could I get an approval for this PR? Finer Controls for S3 Events Notifications;
β’ https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/76
Could I get an approval for this PR? Finer Controls for S3 Events Notifications;
β’ https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/76
B
Bruceabout 2 months ago
bumping default python version on datadog-lambda-forwarder like the module:
https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/91
https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/pull/91
C
Cilas Beltrame2 months ago
just re-pinging this again
N
Nitin2 months ago
Hello everyone, can you please review this PR
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/278
B
Bruce3 months ago
client vpn component broke after latest update:
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
https://github.com/cloudposse-terraform-components/aws-ec2-client-vpn/pull/47
M
Marat Bakeev3 months ago
Hi everyone, can you please review this PR - https://github.com/cloudposse-terraform-components/aws-eks-alb-controller-ingress-class/pull/50
M
Michael3 months ago
May I get a review on this Geodesic PR? https://github.com/cloudposse/geodesic/pull/980
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
It includes:
- Codespell typo fixes
- Improve shell script quality and security by fixing unquoted variables and unsafe array splitting patterns identified by ShellCheck
- Replace unsafe array assignment patterns like
array=($(command)) with the more robust mapfile -t array < <(command) syntax- Quote all variable expansions to prevent word splitting and globbing
- Fix command substitutions that could break with special characters
T
Tyler Rankin3 months ago
Irregular contributor here π
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
Small change to set some limits on labels due to AWS resource character limits. Not sure if there are additional changes to
/test that need to be made. Thanks!https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/73
D
david3 months ago
May I get a review on this SQS -> Lambda trigger please https://github.com/cloudposse-terraform-components/aws-lambda/pull/44
E
Y
Yevdokiia Mazhak3 months ago
hello!
anyone that can have a look at https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/162?
anyone that can have a look at https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/162?
T
Tomasz GΕuch3 months ago
Hi folks,
could I ask you to review https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/96? This change isn't mine, but I've been testing it recently and it works great. The current version of this module has one simple but serious drawback that makes it difficult to use in a real environment.
could I ask you to review https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/96? This change isn't mine, but I've been testing it recently and it works great. The current version of this module has one simple but serious drawback that makes it difficult to use in a real environment.
M
Michael3 months ago
Would I be able to get a review on changing the Helm provider version constraint from
for the EKS Datadog Agent component?
https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/69
>= 2.7 to ~> 2.7for the EKS Datadog Agent component?
https://github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/69
M
Michael3 months ago
Can I get a PR review on this Elasticsearch component improvement? This introduces new configuration options and refactors how key variables are set and passed to the Elasticsearch module. The main focus is on improving flexibility for domain and subdomain naming, advanced security options, and storage configuration, while making these options configurable via input variables
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
N
Nitin4 months ago
Hi, i just added dualstack support in the aws efs repo. can i get review on the PR
https://github.com/cloudposse/terraform-aws-efs/pull/163
https://github.com/cloudposse/terraform-aws-efs/pull/163
M
Musthaq4 months ago
Hi,
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
B
Bruce4 months ago
adding userdata and enhanced monitoring to karpenter ec2 node class
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/52
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/52
Michael4 months ago
Would I be able to get a review on this Elasticsearch component updates that introduces new configuration options and refactors how key variables are set and passed to the Elasticsearch module?
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
https://github.com/cloudposse-terraform-components/aws-elasticsearch/pull/69
Musthaq4 months ago
Hi,
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
Can i get a review on this PR ?
https://github.com/cloudposse-terraform-components/aws-config-bucket/pull/35
Michael4 months ago
Could I please get a review for adding a new output
https://github.com/cloudposse-terraform-components/aws-alb/pull/53
certificate_arn for the ALB component?https://github.com/cloudposse-terraform-components/aws-alb/pull/53
Jan Costandius4 months ago(edited)
Miniature PR for the ALB module. https://github.com/cloudposse/terraform-aws-alb/pull/205